Skip to content

Conversation

@jeffbl
Copy link
Member

@jeffbl jeffbl commented Jan 13, 2026

This causes diagrams to completely fail, so I'm going to merge this tentative fix, but this should really be looked at in more detail. Tested on unicorn with override, and it prevents the timeout, but I do not know the implications to the actual rendering.

TLDR: adds a break for a loop that never exited, causing timeouts and lack of any tactile rendering.

resolves #1186 , which describes the fix and potential implications

Please ensure you've followed the checklist and provide all the required information before requesting a review.
If you do not have everything applicable to your PR, it will not be reviewed!
If you don't know what something is or if it applies to you, ask!

Please note that PRs from external contributors who have not agreed to our Contributor License Agreement will not be considered.
To accept it, include I agree to the [current Contributor License Agreement](/CLA.md) in this pull request.

Don't delete below this line.


Required Information

  • I referenced the issue addressed in this PR.
  • I described the changes made and how these address the issue.
  • I described how I tested these changes.

Coding/Commit Requirements

  • I followed applicable coding standards where appropriate (e.g., PEP8)
  • I have not committed any models or other large files.

New Component Checklist (mandatory for new microservices)

  • I added an entry to docker-compose.yml and build.yml.
  • I created A CI workflow under .github/workflows.
  • I have created a README.md file that describes what the component does and what it depends on (other microservices, ML models, etc.).

OR

  • I have not added a new component in this PR.

@jeffbl jeffbl self-assigned this Jan 13, 2026
@jeffbl jeffbl merged commit f0403ec into main Jan 13, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

multistage-diagram-tactile-svg-handler times out on some textbook diagrams

2 participants