Merged
Conversation
feat(ops): implement dockerization, docker-compose, and github actions ci
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
📝 WalkthroughWalkthroughAdds containerization and CI: multi-stage Dockerfile, docker-compose, .dockerignore, DOCKER_INSTRUCTIONS.md, and a GitHub Actions workflow that lints/typechecks then builds the Docker image; also includes small frontend lint fixes, ESLint directive adjustments, and hook/effect dependency updates. Changes
Sequence Diagram(s)mermaid Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.dockerignore:
- Around line 1-7: Add patterns to the .dockerignore to exclude local env files
from the build context so secrets aren't copied into the builder layers: update
the .dockerignore (referencing the existing .dockerignore file and the
Dockerfile's builder stage that uses COPY . .) to ignore ".env*" while
explicitly allowing ".env.example" to remain available; ensure the pattern order
and any negation (allow) keeps .env.example accessible.
In @.github/workflows/ci.yml:
- Around line 41-50: The CI step "Build Docker Image" (uses:
docker/build-push-action@v5) only passes NEXT_TELEMETRY_DISABLED via build-args;
add the required NEXT_PUBLIC_FIREBASE_* build-args so Next.js can bake them into
the build. Update the build-args for the "Build Docker Image" step to include
the public Firebase variables (e.g. NEXT_PUBLIC_FIREBASE_API_KEY,
NEXT_PUBLIC_FIREBASE_AUTH_DOMAIN, NEXT_PUBLIC_FIREBASE_PROJECT_ID,
NEXT_PUBLIC_FIREBASE_APP_ID, etc.) and map each to the corresponding GitHub
repository variable/secret (using the GitHub Actions expression syntax) so those
values are available at build time instead of being omitted.
In `@Dockerfile`:
- Around line 13-16: The Dockerfile currently copies the entire context (COPY .
.) which pulls in .env and relies on it during RUN npm run build for
NEXT_PUBLIC_FIREBASE_* values; instead declare build args (ARG
NEXT_PUBLIC_FIREBASE_API_KEY, ARG NEXT_PUBLIC_FIREBASE_AUTH_DOMAIN, etc.) before
the build step and set them to environment variables (ENV
NEXT_PUBLIC_FIREBASE_API_KEY=$NEXT_PUBLIC_FIREBASE_API_KEY ...) so npm run build
can access them without copying .env; update the Dockerfile to accept those
build-time args and remove dependency on .env being present in the image,
keeping the COPY . . but ensuring ARG/ENV declarations occur prior to RUN npm
run build and reference the NEXT_PUBLIC_FIREBASE_* names used by Next.js.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 7eca3f4e-221d-4db7-a10a-85bdfdc81009
📒 Files selected for processing (6)
.dockerignore.github/workflows/ci.ymlDOCKER_INSTRUCTIONS.mdDockerfiledocker-compose.ymlnext.config.ts
fix(ops): resolve CI lint errors and update docker configuration for …
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (5)
app/dashboard/analytics/page.tsx (1)
57-59: Good improvement to error type narrowing.Using
unknowninstead ofanyis correct TypeScript practice. The dualAbortErrorchecks are defensive, though technically redundant sinceDOMExceptionextendsErrorin modern environments—the first check would catch both.Could optionally simplify to a single check:
♻️ Optional simplification
- } catch (err: unknown) { - if (err instanceof Error && err.name === 'AbortError') return; - if (err instanceof DOMException && err.name === 'AbortError') return; + } catch (err: unknown) { + if (err instanceof Error && err.name === 'AbortError') return;🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@app/dashboard/analytics/page.tsx` around lines 57 - 59, The catch currently checks AbortError twice (err instanceof Error and err instanceof DOMException); simplify by removing the DOMException branch and keep a single narrowing: if (err instanceof Error && err.name === 'AbortError') return; update the catch clause that uses the variable err so only one AbortError check remains.components/dashboard/SidebarContext.tsx (1)
24-25: Avoid resetting sidebar state from an effect on every route change.This suppression keeps the cascading render pattern in place. A cleaner approach is to key the open state to the pathname that opened the sidebar, so navigation closes it automatically without a
setStateeffect.♻️ Suggested change
export function SidebarProvider({ children }: { children: ReactNode }) { - const [isOpen, setIsOpen] = useState(false); + const [openPathname, setOpenPathname] = useState<string | null>(null); const pathname = usePathname(); - - // Close sidebar on route change - useEffect(() => { - // eslint-disable-next-line react-hooks/set-state-in-effect - setIsOpen(false); - }, [pathname]); + const isOpen = openPathname === pathname; @@ useEffect(() => { const handleEscape = (e: KeyboardEvent) => { - if (e.key === 'Escape') setIsOpen(false); + if (e.key === 'Escape') setOpenPathname(null); }; if (isOpen) document.addEventListener('keydown', handleEscape); return () => document.removeEventListener('keydown', handleEscape); @@ <SidebarContext.Provider value={{ isOpen, - toggle: () => setIsOpen(prev => !prev), - close: () => setIsOpen(false), + toggle: () => setOpenPathname(prev => (prev === pathname ? null : pathname)), + close: () => setOpenPathname(null), }}>🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@components/dashboard/SidebarContext.tsx` around lines 24 - 25, The effect that calls setIsOpen(false) on every route change should be removed and the open state should be keyed to the pathname that opened the sidebar: add a new state like openedByPathname (in SidebarContext) and when opening the sidebar set openedByPathname = current pathname (useLocation.pathname) and isOpen = true; when determining visibility treat the sidebar as open only if isOpen is true AND openedByPathname === current pathname, and update the close/open helper functions (e.g., your openSidebar/closeSidebar setters and setIsOpen) to maintain openedByPathname accordingly; remove the route-change effect entirely so navigation implicitly closes the sidebar when pathname differs.app/interview/[id]/result/page.tsx (1)
1-1: Scope theno-explicit-anysuppression to the actual type gap.Line 1 disables the rule for the whole module, but the only visible offender is
detail: anylater in the file. Please replace that with an indexed type fromIEvaluationand drop the file-wide disable so the rest of the page keeps full type-checking.♻️ Suggested tightening
-/* eslint-disable `@typescript-eslint/no-explicit-any` */ 'use client'; import { useState, useEffect, use } from 'react'; @@ interface PageProps { params: Promise<{ id: string }>; } + +type StructuralDetail = IEvaluation['structural']['details'][number]; @@ - {structural.details.map((detail: any, i: number) => ( + {structural.details.map((detail: StructuralDetail, i: number) => (🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@app/interview/`[id]/result/page.tsx at line 1, Remove the file-wide "eslint-disable `@typescript-eslint/no-explicit-any`" and instead tighten the single weak spot by replacing the explicit any on the detail parameter/prop with the appropriate indexed type from IEvaluation (e.g. change "detail: any" to "detail: IEvaluation['<correctKey>']" or the actual property key from the IEvaluation interface), ensuring imports reference IEvaluation and no other any-suppressions remain in the module.src/lib/firebase/AuthContext.tsx (1)
24-25: Remove the suppression by fixing the initialisLoadingstate.This still does a synchronous state flip on mount when
authis unavailable. InitializeisLoadingfromauthinstead and return early here, so the extra render and the lint suppression both go away.♻️ Suggested change
export function AuthProvider({ children }: { children: React.ReactNode }) { const [user, setUser] = useState<User | null>(null); - const [isLoading, setIsLoading] = useState(true); + const [isLoading, setIsLoading] = useState(() => Boolean(auth)); useEffect(() => { - if (!auth) { - // eslint-disable-next-line react-hooks/set-state-in-effect - setIsLoading(false); - return; - } + if (!auth) return; return onAuthStateChanged(auth, (u) => { setUser(u); setIsLoading(false); });🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/lib/firebase/AuthContext.tsx` around lines 24 - 25, The eslint suppression and synchronous state flip come from initializing isLoading true then calling setIsLoading(false) in the mount effect; instead initialize the isLoading state from the existing auth value (e.g., const [isLoading, setIsLoading] = useState(!!auth) or similar) and remove the setIsLoading(false) call and its eslint-disable comment in the effect, and add an early return in the component/effect when auth is already present so no extra render occurs; update references to isLoading and the effect around setIsLoading to rely on the initial state and early return..github/workflows/ci.yml (1)
1-9: Lock down the workflow token permissions.This workflow appears to need read-only repository access. Declaring
permissions: contents: readavoids inheriting broader defaults.Suggested change
name: SystemCraft CI +permissions: + contents: read + on:🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/ci.yml around lines 1 - 9, The workflow currently inherits default token permissions; add an explicit permissions block at the top level of the SystemCraft CI workflow to restrict the GITHUB_TOKEN to read-only repository contents (declare permissions: contents: read) so the pipeline only has the minimal needed access; update the top-level of the file (near the workflow name/trigger settings shown in the diff) to include this permissions stanza.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@app/dashboard/analytics/page.tsx`:
- Line 76: The useEffect dependency array in app/dashboard/analytics/page.tsx
currently includes the full user object which can change references and cause
redundant re-renders; update the dependency to use a stable identifier instead
(replace user with user?.uid) so the effect only re-runs when the authenticated
user's UID actually changes; locate the effect that depends on isAuthenticated,
user, retryCounter (created alongside useRequireAuth) and change the dependency
list to [isAuthenticated, user?.uid, retryCounter], leaving the effect body
intact.
In `@eslint_output.txt`:
- Around line 1-176: Remove the committed build output file eslint_output.txt
from the repository and prevent future commits: delete the file from the index
(git rm --cached eslint_output.txt or remove+commit), add eslint_output.txt to
.gitignore (or a broader build output pattern), and commit the .gitignore
change; ensure CI/workflows or scripts do not write build logs into the source
tree. If you must purge it from history, run a history-rewrite (e.g., git
filter-branch or git filter-repo) as a follow-up with team coordination.
- Around line 2-113: Each of the listed useCallback hooks (handleDrop,
handleNodeMouseDown, handleNodeMouseUp, handleMouseMove, handleDeleteSelected)
reads the readOnly variable but does not include it in their dependency arrays,
causing React Compiler to skip memoization; fix by adding readOnly to each
callback's dependency array (or refactor to read a stable ref like readOnlyRef
inside the callbacks) so the declared dependencies match the inferred ones and
preserve memoization.
---
Nitpick comments:
In @.github/workflows/ci.yml:
- Around line 1-9: The workflow currently inherits default token permissions;
add an explicit permissions block at the top level of the SystemCraft CI
workflow to restrict the GITHUB_TOKEN to read-only repository contents (declare
permissions: contents: read) so the pipeline only has the minimal needed access;
update the top-level of the file (near the workflow name/trigger settings shown
in the diff) to include this permissions stanza.
In `@app/dashboard/analytics/page.tsx`:
- Around line 57-59: The catch currently checks AbortError twice (err instanceof
Error and err instanceof DOMException); simplify by removing the DOMException
branch and keep a single narrowing: if (err instanceof Error && err.name ===
'AbortError') return; update the catch clause that uses the variable err so only
one AbortError check remains.
In `@app/interview/`[id]/result/page.tsx:
- Line 1: Remove the file-wide "eslint-disable
`@typescript-eslint/no-explicit-any`" and instead tighten the single weak spot by
replacing the explicit any on the detail parameter/prop with the appropriate
indexed type from IEvaluation (e.g. change "detail: any" to "detail:
IEvaluation['<correctKey>']" or the actual property key from the IEvaluation
interface), ensuring imports reference IEvaluation and no other any-suppressions
remain in the module.
In `@components/dashboard/SidebarContext.tsx`:
- Around line 24-25: The effect that calls setIsOpen(false) on every route
change should be removed and the open state should be keyed to the pathname that
opened the sidebar: add a new state like openedByPathname (in SidebarContext)
and when opening the sidebar set openedByPathname = current pathname
(useLocation.pathname) and isOpen = true; when determining visibility treat the
sidebar as open only if isOpen is true AND openedByPathname === current
pathname, and update the close/open helper functions (e.g., your
openSidebar/closeSidebar setters and setIsOpen) to maintain openedByPathname
accordingly; remove the route-change effect entirely so navigation implicitly
closes the sidebar when pathname differs.
In `@src/lib/firebase/AuthContext.tsx`:
- Around line 24-25: The eslint suppression and synchronous state flip come from
initializing isLoading true then calling setIsLoading(false) in the mount
effect; instead initialize the isLoading state from the existing auth value
(e.g., const [isLoading, setIsLoading] = useState(!!auth) or similar) and remove
the setIsLoading(false) call and its eslint-disable comment in the effect, and
add an early return in the component/effect when auth is already present so no
extra render occurs; update references to isLoading and the effect around
setIsLoading to rely on the initial state and early return.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 60ede319-9fda-4793-baa7-9d34cb6dcce6
📒 Files selected for processing (14)
.dockerignore.github/workflows/ci.ymlDockerfileapp/api/user/analytics/route.tsapp/dashboard/analytics/page.tsxapp/interview/[id]/page.tsxapp/interview/[id]/result/page.tsxcomponents/ArchitectureField.tsxcomponents/canvas/DesignCanvas.tsxcomponents/dashboard/SidebarContext.tsxcomponents/interview/InterviewerPanel.tsxeslint_output.txtsrc/hooks/useInterviewTimer.tssrc/lib/firebase/AuthContext.tsx
✅ Files skipped from review due to trivial changes (4)
- components/canvas/DesignCanvas.tsx
- app/api/user/analytics/route.ts
- components/interview/InterviewerPanel.tsx
- components/ArchitectureField.tsx
🚧 Files skipped from review as they are similar to previous changes (2)
- Dockerfile
- .dockerignore
| controller.abort(); | ||
| }; | ||
| }, [isAuthenticated, user?.uid, retryCounter]); | ||
| }, [isAuthenticated, user, retryCounter]); |
There was a problem hiding this comment.
Using full user object in dependency array risks infinite re-renders and redundant fetches.
The codebase pattern in app/interview/page.tsx uses user?.uid as the dependency specifically to prevent re-creation when the user object reference changes. The useRequireAuth hook returns a new object reference on every render, and the Firebase User object has many properties that can trigger unnecessary effect re-runs.
Using user instead of user?.uid means:
- The effect may fire repeatedly even when the authenticated user hasn't changed
- Potential for excessive API calls and degraded performance
- Risk of render loops if state updates cause user reference changes
🐛 Recommended fix
- }, [isAuthenticated, user, retryCounter]);
+ }, [isAuthenticated, user?.uid, retryCounter]);📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| }, [isAuthenticated, user, retryCounter]); | |
| }, [isAuthenticated, user?.uid, retryCounter]); |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@app/dashboard/analytics/page.tsx` at line 76, The useEffect dependency array
in app/dashboard/analytics/page.tsx currently includes the full user object
which can change references and cause redundant re-renders; update the
dependency to use a stable identifier instead (replace user with user?.uid) so
the effect only re-runs when the authenticated user's UID actually changes;
locate the effect that depends on isAuthenticated, user, retryCounter (created
alongside useRequireAuth) and change the dependency list to [isAuthenticated,
user?.uid, retryCounter], leaving the effect body intact.
Comment on lines
+1
to
+176
|
|
||
| D:\vertex-club\System-Craft\System-Craft\components\canvas\DesignCanvas.tsx | ||
| 384:34 error Compilation Skipped: Existing memoization could not be preserved | ||
|
|
||
| React Compiler has skipped optimizing this component because the existing manual memoization could not be preserved. The inferred dependencies did not match the manually specified dependencies, which could cause the value to change more or less frequently than expected. The inferred dependency was `readOnly`, but the source dependencies were [nodes, connections, zoom, panOffset, saveToHistory]. Inferred different dependency than source. | ||
|
|
||
| D:\vertex-club\System-Craft\System-Craft\components\canvas\DesignCanvas.tsx:384:34 | ||
| 382 | | ||
| 383 | // Handle dropping a new component from palette | ||
| > 384 | const handleDrop = useCallback((e: React.DragEvent) => { | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| > 385 | if (readOnly) return; | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| > 386 | e.preventDefault(); | ||
| … | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| > 416 | } | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| > 417 | }, [nodes, connections, zoom, panOffset, saveToHistory]); | ||
| | ^^^^ Could not preserve existing manual memoization | ||
| 418 | | ||
| 419 | const handleDragOver = useCallback((e: React.DragEvent) => { | ||
| 420 | e.preventDefault(); react-hooks/preserve-manual-memoization | ||
| 417:6 warning React Hook useCallback has a missing dependency: 'readOnly'. Either include it or remove the dependency array react-hooks/exhaustive-deps | ||
| 438:43 error Compilation Skipped: Existing memoization could not be preserved | ||
|
|
||
| React Compiler has skipped optimizing this component because the existing manual memoization could not be preserved. The inferred dependencies did not match the manually specified dependencies, which could cause the value to change more or less frequently than expected. The inferred dependency was `readOnly`, but the source dependencies were [nodes, connections, toolMode, zoom, saveToHistory]. Inferred different dependency than source. | ||
|
|
||
| D:\vertex-club\System-Craft\System-Craft\components\canvas\DesignCanvas.tsx:438:43 | ||
| 436 | | ||
| 437 | // Handle starting to draw a connection (Shift+Click on node) | ||
| > 438 | const handleNodeMouseDown = useCallback((e: React.MouseEvent, nodeId: string) => { | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| > 439 | if (readOnly) return; | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| > 440 | e.stopPropagation(); | ||
| … | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| > 478 | }); | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| > 479 | }, [nodes, connections, toolMode, zoom, saveToHistory]); | ||
| | ^^^^ Could not preserve existing manual memoization | ||
| 480 | | ||
| 481 | // Handle completing a connection (mouse up on another node) | ||
| 482 | const handleNodeMouseUp = useCallback((e: React.MouseEvent, nodeId: string) => { react-hooks/preserve-manual-memoization | ||
| 479:6 warning React Hook useCallback has a missing dependency: 'readOnly'. Either include it or remove the dependency array react-hooks/exhaustive-deps | ||
| 482:41 error Compilation Skipped: Existing memoization could not be preserved | ||
|
|
||
| React Compiler has skipped optimizing this component because the existing manual memoization could not be preserved. The inferred dependencies did not match the manually specified dependencies, which could cause the value to change more or less frequently than expected. The inferred dependency was `readOnly`, but the source dependencies were [isDrawingConnection, connectionStart, connections, nodes, draggedNodeId, tempNodes, saveToHistory]. Inferred different dependency than source. | ||
|
|
||
| D:\vertex-club\System-Craft\System-Craft\components\canvas\DesignCanvas.tsx:482:41 | ||
| 480 | | ||
| 481 | // Handle completing a connection (mouse up on another node) | ||
| > 482 | const handleNodeMouseUp = useCallback((e: React.MouseEvent, nodeId: string) => { | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| > 483 | if (readOnly) return; | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| > 484 | e.stopPropagation(); | ||
| … | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| > 511 | setDraggedNodeId(null); | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| > 512 | }, [isDrawingConnection, connectionStart, connections, nodes, draggedNodeId, tempNodes, saveToHistory]); | ||
| | ^^^^ Could not preserve existing manual memoization | ||
| 513 | | ||
| 514 | // Handle mouse move | ||
| 515 | const handleMouseMove = useCallback((e: React.MouseEvent) => { react-hooks/preserve-manual-memoization | ||
| 512:6 warning React Hook useCallback has a missing dependency: 'readOnly'. Either include it or remove the dependency array react-hooks/exhaustive-deps | ||
| 515:39 error Compilation Skipped: Existing memoization could not be preserved | ||
|
|
||
| React Compiler has skipped optimizing this component because the existing manual memoization could not be preserved. The inferred dependencies did not match the manually specified dependencies, which could cause the value to change more or less frequently than expected. The inferred dependency was `readOnly`, but the source dependencies were [draggedNodeId, dragOffset, isDrawingConnection, isPanning, panStart, toolMode, zoom]. Inferred different dependency than source. | ||
|
|
||
| D:\vertex-club\System-Craft\System-Craft\components\canvas\DesignCanvas.tsx:515:39 | ||
| 513 | | ||
| 514 | // Handle mouse move | ||
| > 515 | const handleMouseMove = useCallback((e: React.MouseEvent) => { | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| > 516 | if (readOnly && !isPanning) return; | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| > 517 | const rect = canvasRef.current?.getBoundingClientRect(); | ||
| … | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| > 548 | } | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| > 549 | }, [draggedNodeId, dragOffset, isDrawingConnection, isPanning, panStart, toolMode, zoom]); | ||
| | ^^^^ Could not preserve existing manual memoization | ||
| 550 | | ||
| 551 | // Handle mouse up on canvas | ||
| 552 | const handleMouseUp = useCallback(() => { react-hooks/preserve-manual-memoization | ||
| 549:6 warning React Hook useCallback has a missing dependency: 'readOnly'. Either include it or remove the dependency array react-hooks/exhaustive-deps | ||
| 660:44 error Compilation Skipped: Existing memoization could not be preserved | ||
|
|
||
| React Compiler has skipped optimizing this component because the existing manual memoization could not be preserved. The inferred dependencies did not match the manually specified dependencies, which could cause the value to change more or less frequently than expected. The inferred dependency was `readOnly`, but the source dependencies were [selectedNodeId, selectedConnectionId, nodes, connections, saveToHistory]. Inferred different dependency than source. | ||
|
|
||
| D:\vertex-club\System-Craft\System-Craft\components\canvas\DesignCanvas.tsx:660:44 | ||
| 658 | | ||
| 659 | // Delete selected node or connection | ||
| > 660 | const handleDeleteSelected = useCallback(() => { | ||
| | ^^^^^^^ | ||
| > 661 | if (readOnly) return; | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| > 662 | if (selectedNodeId) { | ||
| … | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| > 671 | } | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| > 672 | }, [selectedNodeId, selectedConnectionId, nodes, connections, saveToHistory]); | ||
| | ^^^^ Could not preserve existing manual memoization | ||
| 673 | | ||
| 674 | // Keyboard shortcuts | ||
| 675 | useEffect(() => { react-hooks/preserve-manual-memoization | ||
| 672:6 warning React Hook useCallback has a missing dependency: 'readOnly'. Either include it or remove the dependency array react-hooks/exhaustive-deps | ||
| 707:6 warning React Hook useEffect has a missing dependency: 'readOnly'. Either include it or remove the dependency array react-hooks/exhaustive-deps | ||
|
|
||
| D:\vertex-club\System-Craft\System-Craft\components\dashboard\Sidebar.tsx | ||
| 3:29 warning 'useCallback' is defined but never used @typescript-eslint/no-unused-vars | ||
|
|
||
| D:\vertex-club\System-Craft\System-Craft\components\dashboard\SidebarContext.tsx | ||
| 24:9 error Error: Calling setState synchronously within an effect can trigger cascading renders | ||
|
|
||
| Effects are intended to synchronize state between React and external systems such as manually updating the DOM, state management libraries, or other platform APIs. In general, the body of an effect should do one or both of the following: | ||
| * Update external systems with the latest state from React. | ||
| * Subscribe for updates from some external system, calling setState in a callback function when external state changes. | ||
|
|
||
| Calling setState synchronously within an effect body causes cascading renders that can hurt performance, and is not recommended. (https://react.dev/learn/you-might-not-need-an-effect). | ||
|
|
||
| D:\vertex-club\System-Craft\System-Craft\components\dashboard\SidebarContext.tsx:24:9 | ||
| 22 | // Close sidebar on route change | ||
| 23 | useEffect(() => { | ||
| > 24 | setIsOpen(false); | ||
| | ^^^^^^^^^ Avoid calling setState() directly within an effect | ||
| 25 | }, [pathname]); | ||
| 26 | | ||
| 27 | // Close on Escape react-hooks/set-state-in-effect | ||
|
|
||
| D:\vertex-club\System-Craft\System-Craft\components\interview\InterviewerPanel.tsx | ||
| 98:59 error `'` can be escaped with `'`, `‘`, `'`, `’` react/no-unescaped-entities | ||
|
|
||
| D:\vertex-club\System-Craft\System-Craft\src\hooks\useInterviewTimer.ts | ||
| 43:5 error Error: Cannot access refs during render | ||
|
|
||
| React refs are values that are not needed for rendering. Refs should only be accessed outside of render, such as in event handlers or effects. Accessing a ref value (the `current` property) during render can cause your component not to update as expected (https://react.dev/reference/react/useRef). | ||
|
|
||
| D:\vertex-club\System-Craft\System-Craft\src\hooks\useInterviewTimer.ts:43:5 | ||
| 41 | }: UseInterviewTimerOptions): TimerState { | ||
| 42 | const onTimeUpRef = useRef(onTimeUp); | ||
| > 43 | onTimeUpRef.current = onTimeUp; | ||
| | ^^^^^^^^^^^^^^^^^^^ Cannot update ref during render | ||
| 44 | | ||
| 45 | const hasExpiredRef = useRef(false); | ||
| 46 | react-hooks/refs | ||
|
|
||
| D:\vertex-club\System-Craft\System-Craft\src\lib\db\mongoose.ts | ||
| 10:5 warning Unused eslint-disable directive (no problems were reported from 'no-var') | ||
|
|
||
| D:\vertex-club\System-Craft\System-Craft\src\lib\firebase\AuthContext.tsx | ||
| 24:13 error Error: Calling setState synchronously within an effect can trigger cascading renders | ||
|
|
||
| Effects are intended to synchronize state between React and external systems such as manually updating the DOM, state management libraries, or other platform APIs. In general, the body of an effect should do one or both of the following: | ||
| * Update external systems with the latest state from React. | ||
| * Subscribe for updates from some external system, calling setState in a callback function when external state changes. | ||
|
|
||
| Calling setState synchronously within an effect body causes cascading renders that can hurt performance, and is not recommended. (https://react.dev/learn/you-might-not-need-an-effect). | ||
|
|
||
| D:\vertex-club\System-Craft\System-Craft\src\lib\firebase\AuthContext.tsx:24:13 | ||
| 22 | useEffect(() => { | ||
| 23 | if (!auth) { | ||
| > 24 | setIsLoading(false); | ||
| | ^^^^^^^^^^^^ Avoid calling setState() directly within an effect | ||
| 25 | return; | ||
| 26 | } | ||
| 27 | return onAuthStateChanged(auth, (u) => { react-hooks/set-state-in-effect | ||
|
|
||
| ✖ 17 problems (9 errors, 8 warnings) | ||
| 0 errors and 1 warning potentially fixable with the `--fix` option. | ||
|
|
There was a problem hiding this comment.
Drop this generated lint log from the repo.
This file is build output, not source, and it also commits machine-specific absolute paths. It will drift out of date immediately and adds noise without fixing any of the reported issues.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@eslint_output.txt` around lines 1 - 176, Remove the committed build output
file eslint_output.txt from the repository and prevent future commits: delete
the file from the index (git rm --cached eslint_output.txt or remove+commit),
add eslint_output.txt to .gitignore (or a broader build output pattern), and
commit the .gitignore change; ensure CI/workflows or scripts do not write build
logs into the source tree. If you must purge it from history, run a
history-rewrite (e.g., git filter-branch or git filter-repo) as a follow-up with
team coordination.
Comment on lines
+2
to
+113
| D:\vertex-club\System-Craft\System-Craft\components\canvas\DesignCanvas.tsx | ||
| 384:34 error Compilation Skipped: Existing memoization could not be preserved | ||
|
|
||
| React Compiler has skipped optimizing this component because the existing manual memoization could not be preserved. The inferred dependencies did not match the manually specified dependencies, which could cause the value to change more or less frequently than expected. The inferred dependency was `readOnly`, but the source dependencies were [nodes, connections, zoom, panOffset, saveToHistory]. Inferred different dependency than source. | ||
|
|
||
| D:\vertex-club\System-Craft\System-Craft\components\canvas\DesignCanvas.tsx:384:34 | ||
| 382 | | ||
| 383 | // Handle dropping a new component from palette | ||
| > 384 | const handleDrop = useCallback((e: React.DragEvent) => { | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| > 385 | if (readOnly) return; | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| > 386 | e.preventDefault(); | ||
| … | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| > 416 | } | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| > 417 | }, [nodes, connections, zoom, panOffset, saveToHistory]); | ||
| | ^^^^ Could not preserve existing manual memoization | ||
| 418 | | ||
| 419 | const handleDragOver = useCallback((e: React.DragEvent) => { | ||
| 420 | e.preventDefault(); react-hooks/preserve-manual-memoization | ||
| 417:6 warning React Hook useCallback has a missing dependency: 'readOnly'. Either include it or remove the dependency array react-hooks/exhaustive-deps | ||
| 438:43 error Compilation Skipped: Existing memoization could not be preserved | ||
|
|
||
| React Compiler has skipped optimizing this component because the existing manual memoization could not be preserved. The inferred dependencies did not match the manually specified dependencies, which could cause the value to change more or less frequently than expected. The inferred dependency was `readOnly`, but the source dependencies were [nodes, connections, toolMode, zoom, saveToHistory]. Inferred different dependency than source. | ||
|
|
||
| D:\vertex-club\System-Craft\System-Craft\components\canvas\DesignCanvas.tsx:438:43 | ||
| 436 | | ||
| 437 | // Handle starting to draw a connection (Shift+Click on node) | ||
| > 438 | const handleNodeMouseDown = useCallback((e: React.MouseEvent, nodeId: string) => { | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| > 439 | if (readOnly) return; | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| > 440 | e.stopPropagation(); | ||
| … | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| > 478 | }); | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| > 479 | }, [nodes, connections, toolMode, zoom, saveToHistory]); | ||
| | ^^^^ Could not preserve existing manual memoization | ||
| 480 | | ||
| 481 | // Handle completing a connection (mouse up on another node) | ||
| 482 | const handleNodeMouseUp = useCallback((e: React.MouseEvent, nodeId: string) => { react-hooks/preserve-manual-memoization | ||
| 479:6 warning React Hook useCallback has a missing dependency: 'readOnly'. Either include it or remove the dependency array react-hooks/exhaustive-deps | ||
| 482:41 error Compilation Skipped: Existing memoization could not be preserved | ||
|
|
||
| React Compiler has skipped optimizing this component because the existing manual memoization could not be preserved. The inferred dependencies did not match the manually specified dependencies, which could cause the value to change more or less frequently than expected. The inferred dependency was `readOnly`, but the source dependencies were [isDrawingConnection, connectionStart, connections, nodes, draggedNodeId, tempNodes, saveToHistory]. Inferred different dependency than source. | ||
|
|
||
| D:\vertex-club\System-Craft\System-Craft\components\canvas\DesignCanvas.tsx:482:41 | ||
| 480 | | ||
| 481 | // Handle completing a connection (mouse up on another node) | ||
| > 482 | const handleNodeMouseUp = useCallback((e: React.MouseEvent, nodeId: string) => { | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| > 483 | if (readOnly) return; | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| > 484 | e.stopPropagation(); | ||
| … | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| > 511 | setDraggedNodeId(null); | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| > 512 | }, [isDrawingConnection, connectionStart, connections, nodes, draggedNodeId, tempNodes, saveToHistory]); | ||
| | ^^^^ Could not preserve existing manual memoization | ||
| 513 | | ||
| 514 | // Handle mouse move | ||
| 515 | const handleMouseMove = useCallback((e: React.MouseEvent) => { react-hooks/preserve-manual-memoization | ||
| 512:6 warning React Hook useCallback has a missing dependency: 'readOnly'. Either include it or remove the dependency array react-hooks/exhaustive-deps | ||
| 515:39 error Compilation Skipped: Existing memoization could not be preserved | ||
|
|
||
| React Compiler has skipped optimizing this component because the existing manual memoization could not be preserved. The inferred dependencies did not match the manually specified dependencies, which could cause the value to change more or less frequently than expected. The inferred dependency was `readOnly`, but the source dependencies were [draggedNodeId, dragOffset, isDrawingConnection, isPanning, panStart, toolMode, zoom]. Inferred different dependency than source. | ||
|
|
||
| D:\vertex-club\System-Craft\System-Craft\components\canvas\DesignCanvas.tsx:515:39 | ||
| 513 | | ||
| 514 | // Handle mouse move | ||
| > 515 | const handleMouseMove = useCallback((e: React.MouseEvent) => { | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| > 516 | if (readOnly && !isPanning) return; | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| > 517 | const rect = canvasRef.current?.getBoundingClientRect(); | ||
| … | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| > 548 | } | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| > 549 | }, [draggedNodeId, dragOffset, isDrawingConnection, isPanning, panStart, toolMode, zoom]); | ||
| | ^^^^ Could not preserve existing manual memoization | ||
| 550 | | ||
| 551 | // Handle mouse up on canvas | ||
| 552 | const handleMouseUp = useCallback(() => { react-hooks/preserve-manual-memoization | ||
| 549:6 warning React Hook useCallback has a missing dependency: 'readOnly'. Either include it or remove the dependency array react-hooks/exhaustive-deps | ||
| 660:44 error Compilation Skipped: Existing memoization could not be preserved | ||
|
|
||
| React Compiler has skipped optimizing this component because the existing manual memoization could not be preserved. The inferred dependencies did not match the manually specified dependencies, which could cause the value to change more or less frequently than expected. The inferred dependency was `readOnly`, but the source dependencies were [selectedNodeId, selectedConnectionId, nodes, connections, saveToHistory]. Inferred different dependency than source. | ||
|
|
||
| D:\vertex-club\System-Craft\System-Craft\components\canvas\DesignCanvas.tsx:660:44 | ||
| 658 | | ||
| 659 | // Delete selected node or connection | ||
| > 660 | const handleDeleteSelected = useCallback(() => { | ||
| | ^^^^^^^ | ||
| > 661 | if (readOnly) return; | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| > 662 | if (selectedNodeId) { | ||
| … | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| > 671 | } | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| > 672 | }, [selectedNodeId, selectedConnectionId, nodes, connections, saveToHistory]); | ||
| | ^^^^ Could not preserve existing manual memoization | ||
| 673 | | ||
| 674 | // Keyboard shortcuts | ||
| 675 | useEffect(() => { react-hooks/preserve-manual-memoization | ||
| 672:6 warning React Hook useCallback has a missing dependency: 'readOnly'. Either include it or remove the dependency array react-hooks/exhaustive-deps | ||
| 707:6 warning React Hook useEffect has a missing dependency: 'readOnly'. Either include it or remove the dependency array react-hooks/exhaustive-deps |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
FILE="$(fd 'DesignCanvas.tsx$' . | head -n 1)"
echo "Inspecting: $FILE"
sed -n '380,690p' "$FILE"
echo
echo "Relevant callback definitions and dependency arrays:"
rg -n -C2 'const handle(Drop|NodeMouseDown|NodeMouseUp|MouseMove|DeleteSelected)|\], \[|readOnly' "$FILE"Repository: Shashank0701-byte/System-Craft
Length of output: 17667
Five useCallback hooks in DesignCanvas.tsx are missing the readOnly dependency and must be fixed.
The following callbacks read readOnly without declaring it in their dependency arrays, preventing React Compiler from optimizing them:
handleDrop(line 385): dependency array[nodes, connections, zoom, panOffset, saveToHistory]handleNodeMouseDown(line 439): dependency array[nodes, connections, toolMode, zoom, saveToHistory]handleNodeMouseUp(line 483): dependency array[isDrawingConnection, connectionStart, connections, nodes, draggedNodeId, tempNodes, saveToHistory]handleMouseMove(line 516): dependency array[draggedNodeId, dragOffset, isDrawingConnection, isPanning, panStart, toolMode, zoom]handleDeleteSelected(line 661): dependency array[selectedNodeId, selectedConnectionId, nodes, connections, saveToHistory]
Each callback accesses readOnly at the start (if (readOnly) return;) and must either include readOnly in the dependency array or refactor to avoid capturing it directly.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@eslint_output.txt` around lines 2 - 113, Each of the listed useCallback hooks
(handleDrop, handleNodeMouseDown, handleNodeMouseUp, handleMouseMove,
handleDeleteSelected) reads the readOnly variable but does not include it in
their dependency arrays, causing React Compiler to skip memoization; fix by
adding readOnly to each callback's dependency array (or refactor to read a
stable ref like readOnlyRef inside the callbacks) so the declared dependencies
match the inferred ones and preserve memoization.
fix(ops): resolve CI lint errors and update docker configuration for …
There was a problem hiding this comment.
Actionable comments posted: 2
♻️ Duplicate comments (1)
app/dashboard/analytics/page.tsx (1)
75-75:⚠️ Potential issue | 🟠 MajorUse
user?.uidinstead ofuserin dependency array.The full
userobject reference can change on each Firebase auth emission (as shown insrc/lib/firebase/AuthContext.tsx:27), potentially causing unnecessary effect re-runs and redundant API calls. Use the stableuser?.uididentifier instead.🐛 Proposed fix
- }, [isAuthenticated, user, retryCounter]); + }, [isAuthenticated, user?.uid, retryCounter]);🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@app/dashboard/analytics/page.tsx` at line 75, The effect's dependency array currently uses the full user object which can change frequently; update the dependency from user to user?.uid (i.e., use the stable identifier) so the useEffect that depends on isAuthenticated, user, retryCounter instead depends on isAuthenticated, user?.uid, retryCounter; locate the useEffect in page.tsx and replace the user dependency with user?.uid (using optional chaining) to prevent unnecessary reruns and redundant API calls.
🧹 Nitpick comments (2)
app/interview/[id]/result/page.tsx (2)
343-345: Prefer semantic quoting over hardcoded"wrappers.Line 345 is already safe because React escapes
{s}. This change only forces literal quotes around every suggestion, and it can read awkwardly when the suggestion text already contains quotation marks.<q>{s}</q>is clearer and keeps the same escaping behavior.💡 Suggested tweak
- "{s}" + <q>{s}</q>🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@app/interview/`[id]/result/page.tsx around lines 343 - 345, Replace the hardcoded HTML entity wrappers around suggestions in the reasoning.suggestions render with a semantic quotation element: locate the map over reasoning.suggestions in page.tsx (the JSX block that renders each suggestion inside the div with className "p-3..."), remove the literal " wrappers around the interpolated {s} and wrap {s} with a <q> element instead so React still escapes content but semantic quoting is used; keep the existing key and className unchanged.
1-1: Remove the stale file-wideno-explicit-anysuppression.Line 1 now disables the rule for the entire module even though this file no longer uses
any. Keeping it broad will hide future regressions here.✂️ Proposed cleanup
-/* eslint-disable `@typescript-eslint/no-explicit-any` */ 'use client';🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@app/interview/`[id]/result/page.tsx at line 1, Remove the stale file-wide ESLint suppression by deleting the top-line comment "/* eslint-disable `@typescript-eslint/no-explicit-any` */" from the module (app/interview/[id]/result/page.tsx); if a narrow suppression is still required for a specific expression, replace the file-wide disable with an inline or single-line eslint-disable-next-line only at that usage site (target the exact expression instead of the whole file) so the rule isn't globally silenced for the module.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@components/canvas/DesignCanvas.tsx`:
- Line 1: Remove the file-wide "/* eslint-disable */" at the top of DesignCanvas
and instead address the specific lint issues: re-enable linting, fix any
reported warnings (especially hook-related/stale-closure issues in functions
like the component body and any useEffect callbacks), or, if a suppression is
unavoidable, apply scoped comments such as "// eslint-disable-next-line
<rule-name>" immediately above the specific line(s) (for example use "//
eslint-disable-next-line react-hooks/exhaustive-deps" only on the exact
useEffect call) so only the necessary rule is disabled rather than the entire
file.
In `@src/lib/firebase/AuthContext.tsx`:
- Line 20: The isLoading state in AuthContext (const [isLoading, setIsLoading] =
useState(!auth)) is incorrect and causes premature redirects or eternal loading;
change initialization to true and update the effect to explicitly handle the
!auth case by setting setIsLoading(false) and returning early, and keep the
onAuthStateChanged subscription (in the useEffect inside AuthContext) to call
setUser(...) and setIsLoading(false) when the auth state is resolved; locate
references to isLoading, setIsLoading, onAuthStateChanged and the useEffect in
AuthContext.tsx (and ensure consumers like useRequireAuth that read isLoading
behave correctly).
---
Duplicate comments:
In `@app/dashboard/analytics/page.tsx`:
- Line 75: The effect's dependency array currently uses the full user object
which can change frequently; update the dependency from user to user?.uid (i.e.,
use the stable identifier) so the useEffect that depends on isAuthenticated,
user, retryCounter instead depends on isAuthenticated, user?.uid, retryCounter;
locate the useEffect in page.tsx and replace the user dependency with user?.uid
(using optional chaining) to prevent unnecessary reruns and redundant API calls.
---
Nitpick comments:
In `@app/interview/`[id]/result/page.tsx:
- Around line 343-345: Replace the hardcoded HTML entity wrappers around
suggestions in the reasoning.suggestions render with a semantic quotation
element: locate the map over reasoning.suggestions in page.tsx (the JSX block
that renders each suggestion inside the div with className "p-3..."), remove the
literal " wrappers around the interpolated {s} and wrap {s} with a <q>
element instead so React still escapes content but semantic quoting is used;
keep the existing key and className unchanged.
- Line 1: Remove the stale file-wide ESLint suppression by deleting the top-line
comment "/* eslint-disable `@typescript-eslint/no-explicit-any` */" from the
module (app/interview/[id]/result/page.tsx); if a narrow suppression is still
required for a specific expression, replace the file-wide disable with an inline
or single-line eslint-disable-next-line only at that usage site (target the
exact expression instead of the whole file) so the rule isn't globally silenced
for the module.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 795099a4-7ef4-492c-93a3-8ce0e1297b6d
📒 Files selected for processing (9)
.github/workflows/ci.yml.gitignoreapp/dashboard/analytics/page.tsxapp/interview/[id]/result/page.tsxcomponents/canvas/DesignCanvas.tsxcomponents/dashboard/Sidebar.tsxcomponents/dashboard/SidebarContext.tsxsrc/lib/db/mongoose.tssrc/lib/firebase/AuthContext.tsx
✅ Files skipped from review due to trivial changes (3)
- components/dashboard/Sidebar.tsx
- .gitignore
- src/lib/db/mongoose.ts
🚧 Files skipped from review as they are similar to previous changes (2)
- components/dashboard/SidebarContext.tsx
- .github/workflows/ci.yml
fix(ops): resolve CI lint errors and update docker configuration for build-args
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Documentation
Bug Fixes / UX
Chores