Fallback search if container ip is empty. Updated install command in readme#10
Open
bschulz87 wants to merge 3 commits intoShimmur:masterfrom
Open
Fallback search if container ip is empty. Updated install command in readme#10bschulz87 wants to merge 3 commits intoShimmur:masterfrom
bschulz87 wants to merge 3 commits intoShimmur:masterfrom
Conversation
…ail if this also results in empty ip
Author
|
Also feel free to remove the install change if i made a mistake here. I'm not super familiar with the go ecosystem to be honest. |
Contributor
|
cc @danpilch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a fallback search in containers network settings if the regular container ip is an empty string.
Without this patch i got an error when using the proxy connection:
Can't forward traffic to backend tcp/:3306: ssh: rejected: connect failed (Temporary failure in name resolution)Docker version 19.03.5, build 633a0ea838 (Remote Host)
I also updated the readme to use go install instead of go get