Add a -write option
#77
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This parses its argument like the output file. Since that parsing depends on the filesystem we rig up a new context type which ensures the whole system can stay flexible. Note that image-magick also contains a few builtin options like input of patterns and built-in images. We'd presumably load these from bundled files in an install which again are part of a context. Finally, context could also provide acceleration capabilities (including SPIR-V code).
197g
force-pushed
the
sequenced-write
branch
from
fd50879 to
cf967f3
Compare
Contributor
Author
|
I've been sketching -adjoin writes (i.e. multiple frames into a single file in an animated format or a container, avif, tif, webp, gif) here: main...image-rs:wondermagick:sequenced-adjoin-writes This will need better support in Just fyi. |
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the filepath processing this was more complex than it seems at first. I think we'd want to eat the complexity of a new
ArgParseCtxtype now rather than later (see commit message). The testing is an integration test.This is stacked on #76 since it only becomes possible with proper sequence support.
I'm refusing the temptation to extend
imagemagickwith this PR but if we'd want to provide use ofExecutionPlanas a library or even do unit testing then a specialLocationthat writes to a pool of images could also be neat. We should also have the capabilities for output intonull:-(which does not write at all) andfd:1as explained in STDIN, STDOUT, and file descriptors.Feel free to review at your own pace if you want to prioritize operations.