Fix show name sorting to properly group entries by ShowID #507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When sorting by show name, entries with the same show name were being scattered by round number instead of being grouped together. Changed the secondary sort to use showCompare (matching the pattern used by all other column sorts) so entries with the same show name are now properly grouped by ShowID. Fixes sorting behavior in the Shows/Rounds stats list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sorting by show name, entries with the same show name were being scattered by round number instead of being grouped together. Changed the secondary sort to use showCompare (matching the pattern used by all other column sorts) so entries with the same show name are now properly grouped by ShowID.
Fixes sorting behavior in the Shows/Rounds stats list.