Skip to content

Build with Go 1.11 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vvuibert merged 1 commit into from
Oct 30, 2018
Merged

Build with Go 1.11 #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,19 @@
language: go

go:
- 1.9.1
- 1.9.2
- 1.10.2
- 1.11
- master

env:
- DEP_VERSION="0.3.2"
- DEP_VERSION="0.5.0"

sudo: required

services:
- docker

before_install:
# Download the binary to bin folder in $GOPATH
- curl -L -s https://github.com/golang/dep/releases/download/v${DEP_VERSION}/dep-linux-amd64 -o $GOPATH/bin/dep
Expand Down Expand Up @@ -56,7 +57,7 @@ script:
- test -z $(gofmt -s -l $GO_FILES) # Fail if a .go file hasn't been formatted with gofmt
- go test --timeout 5s -v -race ./... # Run all the tests with the race detector enabled
- ./testAndCover.sh # Run the tests again to get coverage info
- go vet ./... # go vet is the official Go static analyzer
- go vet -composites=false ./... # go vet is the official Go static analyzer
Copy link

@sam-obeid sam-obeid Oct 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why disabling composite keys here?

Copy link
Collaborator Author

@vvuibert vvuibert Oct 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because the tests at linkedin were failing linkedin#450
I can't remember exactly the error message

- megacheck ./... # "go vet on steroids" + linter
- gocyclo -over 15 $GO_FILES # forbid code with huge functions
- golint -set_exit_status $(go list ./...) # one last linter
Expand All @@ -65,4 +66,4 @@ script:
# goreleaser will run if the latest version tag matches the current commit
after_success:
- $GOPATH/bin/goveralls -coverprofile=profile.cov -service=travis-ci
- if [[ "$TRAVIS_SECURE_ENV_VARS" == true && "$TRAVIS_GO_VERSION" == "1.9.2" ]]; then docker login -u "$DOCKER_USERNAME" -p "$DOCKER_PASSWORD"; curl -sL https://git.io/goreleaser | bash; fi
- if [[ "$TRAVIS_SECURE_ENV_VARS" == true && "$TRAVIS_GO_VERSION" == "1.11" ]]; then docker login -u "$DOCKER_USERNAME" -p "$DOCKER_PASSWORD"; curl -sL https://git.io/goreleaser | bash; fi
4 changes: 2 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
FROM golang:1.9-alpine as builder
FROM golang:1.11-alpine as builder

ENV DEP_VERSION="0.3.2"
ENV DEP_VERSION="0.5.0"
RUN apk add --no-cache git curl && \
curl -L -s https://github.com/golang/dep/releases/download/v${DEP_VERSION}/dep-linux-amd64 -o $GOPATH/bin/dep && \
chmod +x $GOPATH/bin/dep && \
Expand Down
Loading