Skip to content

Fix flaky Swift preload expiry test#331

Merged
tiagocandido merged 1 commit into
mainfrom
fix-swift-preload-expiry-flake
Jun 25, 2026
Merged

Fix flaky Swift preload expiry test#331
tiagocandido merged 1 commit into
mainfrom
fix-swift-preload-expiry-flake

Conversation

@tiagocandido

Copy link
Copy Markdown
Contributor

Summary

  • give the preload expiry test a 1s freshness margin instead of 0.1s
  • extend the expiry polling timeout to 3s so slow CI has room for the expiry timer
  • keep production preload cache behavior unchanged

Why

The test created an entry with only 0.1s of TTL remaining, then immediately asserted the cache still existed. On slow CI, the entry could become stale before those assertions and invalidate itself.

Test plan

  • shadowenv exec --dir /Users/tiagosantos/src/github.com/Shopify/checkout-kit -- /opt/dev/bin/dev swift test CheckoutWebViewTests
  • shadowenv exec --dir /Users/tiagosantos/src/github.com/Shopify/checkout-kit -- /opt/dev/bin/dev swift test CheckoutWebViewTests

@tiagocandido tiagocandido requested a review from a team as a code owner June 24, 2026 16:31
@tiagocandido tiagocandido force-pushed the fix-swift-preload-expiry-flake branch from 3e181b0 to 5413590 Compare June 25, 2026 08:12
@github-actions

Copy link
Copy Markdown

React Native — Coverage Report

Lines Statements Branches Functions
Coverage: 92%
91.66% (319/348) 87.86% (181/206) 100% (82/82)

@tiagocandido tiagocandido enabled auto-merge (squash) June 25, 2026 08:16
@tiagocandido tiagocandido merged commit cee0483 into main Jun 25, 2026
31 checks passed
@tiagocandido tiagocandido deleted the fix-swift-preload-expiry-flake branch June 25, 2026 08:29
@markmur markmur added the #gsd:50662 Rebase Checkout Kit on UCP label Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

#gsd:50662 Rebase Checkout Kit on UCP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants