[Tophat] refactor: extract shared browserstack client and reuse http client#433
Conversation
11 tasks
11 tasks
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
11 tasks
kieran-osgood-shopify
changed the title
kieran-osgood-shopify
force-pushed
the
kieran-osgood/07-08-addbitriseclientfortophatartifactdiscovery
branch
from
c32b0f5 to
9d98b2e
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/07-10-refactorextractsharedbrowserstackclientandreusehttpclient
branch
from
522efa6 to
a6b3b1f
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/07-08-addbitriseclientfortophatartifactdiscovery
branch
from
9d98b2e to
81d2278
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/07-10-refactorextractsharedbrowserstackclientandreusehttpclient
branch
from
a6b3b1f to
4653cdd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you making?
How to test
Before you merge
Important
platforms/swift/README.mdand/orplatforms/android/README.md)Releasing a new Swift version?
ShopifyCheckoutKit.podspecplatforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftplatforms/swift/README.md(major version only)Releasing a new Embedded Checkout Protocol version?
embeddedCheckoutProtocolAndroidinplatforms/android/gradle/libs.versions.tomlprotocol/languages/kotlin/embedded-checkout-protocol/api/embedded-checkout-protocol.apiif the public API changedReleasing a new Android version?
checkoutKitAndroidinplatforms/android/gradle/libs.versions.tomlplatforms/android/README.mdTip
See the Contributing documentation for the full release process per platform.