Skip to content

Simplify snapit message #6329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gonzaloriestra merged 2 commits into from
Aug 28, 2025
Merged

Simplify snapit message #6329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e88e9e
Simplify /snapit message
gonzaloriestra Aug 27, 2025
7fb3e46
Allow unpinned actions from Shopify
gonzaloriestra Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions .github/workflows/snapit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,16 +26,11 @@ jobs:
- name: Force snapshot changeset
run: "mv .changeset/force-snapshot-build.md.ignore .changeset/force-snapshot-build.md"
- name: Create snapshot version
uses: Shopify/snapit@8ff75631e13281a35f85b373bcadfa2fa12bb21e # pin@v0.0.14
uses: Shopify/snapit@registry-and-package-manager
with:
global_install: 'true'
github_comment_included_packages: '@shopify/cli'
custom_message_suffix: "
> [!TIP]

> If you get an `ETARGET` error, install it with NPM and the flag `--@shopify:registry=https://registry.npmjs.org`


> [!CAUTION]

> After installing, validate the version by running just `shopify` in your terminal.
Expand All @@ -44,6 +39,8 @@ jobs:

> Use `which shopify` to find out which one you are running and uninstall it."
build_script: "pnpm nx run-many --target=bundle --all --skip-nx-cache --output-style=stream && pnpm refresh-manifests"
package_manager: 'npm'
shopify_registry: 'https://registry.npmjs.org'
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
Expand Down
4 changes: 2 additions & 2 deletions packages/features/steps/github-actions.steps.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ When(/I look at the github actions we use/, async function () {

Then(/I see all non-official actions being pinned/, async function () {
const remaining: string[] = this.githubActions.filter(
// we skip the ones from github or from the repo
(action: string) => !action.startsWith('actions/') && !action.startsWith('./'),
// we skip the ones from github, from the repo or from Shopify
(action: string) => !action.startsWith('actions/') && !action.startsWith('./') && !action.startsWith('Shopify/'),
)
const unpinned = remaining.filter(
(action: string) =>
Expand Down