Skip to content

Conversation

@gonzaloriestra
Copy link
Contributor

WHY are these changes introduced?

Continuation of #6599

In Shopify/snapit#32, more params were renamed

WHAT is this pull request doing?

Rename some outdated params in the Snapit workflow

How to test your changes?

Merge and /snapit

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

@gonzaloriestra gonzaloriestra marked this pull request as ready for review November 11, 2025 13:45
@gonzaloriestra gonzaloriestra requested a review from a team as a code owner November 11, 2025 13:45
@github-actions
Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
79.23% (+0.01% 🔼)
13582/17143
🟡 Branches
73.11% (+0.01% 🔼)
6631/9070
🟡 Functions 79.37% 3505/4416
🟡 Lines
79.58% (+0.01% 🔼)
12827/16118

Test suite run success

3356 tests passing in 1372 suites.

Report generated by 🧪jest coverage report action from 6522db0

Copy link
Contributor Author

gonzaloriestra commented Nov 11, 2025

Merge activity

  • Nov 11, 2:30 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Nov 11, 2:30 PM UTC: @gonzaloriestra added this pull request to the GitHub merge queue with Graphite.

@gonzaloriestra gonzaloriestra added this pull request to the merge queue Nov 11, 2025
Merged via the queue into main with commit cfbef78 Nov 11, 2025
29 checks passed
@gonzaloriestra gonzaloriestra deleted the update-snapit-workflow-2 branch November 11, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants