fix: update spacing in MethodCard component#175
Open
bolariin wants to merge 2 commits intoShopify:mainfrom
Open
fix: update spacing in MethodCard component#175bolariin wants to merge 2 commits intoShopify:mainfrom
bolariin wants to merge 2 commits intoShopify:mainfrom
Conversation
Author
|
I've signed the CLA |
devisscher
force-pushed
the
fix/method-card-spacing
branch
from
b2e188b to
4c94db7
Compare
bolariin
force-pushed
the
fix/method-card-spacing
branch
from
4c94db7 to
ef1822c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem is this PR solving?
I noticed an inconsistency with the spacing between the discount type title and the discount class label for the MethodCard component in the native shopify discount
I noticed a difference with spacing between the discount type title and discount class label for the MethodCard component in the native shopify discount MethodCard component and MethodCard component from this package. This pr resolves the inconsistency by updating the spacing to match the native shopify discount MethodCard.
native shopify discount MethodCard
discount app components MethodCard
discount app components MethodCard after change
Reviewers’ hat-rack 🎩
storybookMethodCardBefore requesting reviews
Before you deploy