Apply favicon#1399
Closed
kaibadash wants to merge 1 commit intoShopify:mainfrom
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I set a favicon for maintenance_tasks.
Since maintenance_tasks does not have a favicon configured, the browser falls back to requesting
/favicon.ico, which does not exist in the Rails default, resulting in a 404 in most cases.You can see this happening in the maintenance_tasks demo as well.
I'm not a designer, so it may not be the coolest design, but it should be sufficient for identification purposes.
If you have a better design, I'll be happy to update it.