Add Measured::Temperature unit type#186
Closed
ntn wants to merge 2 commits intodynamic-conversionsfrom
Closed
Conversation
bc22ec8 to
01b94d4
Compare
7b07933 to
30330a9
Compare
01b94d4 to
b39d147
Compare
30330a9 to
248baee
Compare
b39d147 to
320ac2f
Compare
248baee to
ef21a76
Compare
320ac2f to
378c206
Compare
ef21a76 to
4aac0a3
Compare
Add support for arbitrary conversion functions between units, enabling non-proportional relationships like temperature. Units can define conversions as proc pairs (forward/backward) instead of ratios. FunctionalConversionTableBuilder builds conversion tables of procs, composing them for indirect paths. UnitSystem auto-selects the right builder based on whether any unit is functional. Shared builder logic (cycle detection, caching, graph validation) extracted into ConversionTableBuilderBase module. UnitSystemBuilder gets cleaner DSL kwargs: convert_to:, forward:, backward:, description: as an alternative to the value: hash format. Includes Temperature as a proof-of-concept test fixture demonstrating C, K, and F conversions.
Add Temperature as an opt-in unit type with Celsius, Kelvin, and Fahrenheit. Not included in the default require - users opt in with: gem 'measured', require: ['measured', 'measured/temperature'] Or manually: require 'measured/temperature'
378c206 to
c6f7bb1
Compare
4aac0a3 to
b56e8c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
Measured::Temperatureas the first dynamic unit type, demonstrating the proc-based conversion system from #185.Includes three units:
celsius + 273.15celsius * 9/5 + 32Opt-in only
Temperature is not included in the default
require "measured". Users opt in explicitly:This keeps the default gem lightweight and avoids loading dynamic conversion infrastructure for users who only need static units (length, weight, volume).
Usage
Test plan
require 'measured'alone does not load Temperature