Open
Conversation
Contributor
Author
|
cc. @kmcphillips |
kmcphillips
reviewed
Mar 10, 2026
| - uses: actions/checkout@50fbc622fc4ef5163becd7fab6573eac35f8462e # v1.2.0 | ||
| - uses: actions/checkout@v4 | ||
| - name: Set up Ruby ${{ matrix.ruby }} | ||
| uses: ruby/setup-ruby@e34163cd15f4bb403dcd72d98e295997e6a55798 # v1.238.0 |
Contributor
There was a problem hiding this comment.
I wonder why these were pinned down. 🤔
Contributor
Author
There was a problem hiding this comment.
Maybe supply chain security? Unpinning means we get auto-updates with new Ruby versions and bug fixes so I think we should make this change but I don't have the context in this repo to know for sure
Update CI to test against currently supported Ruby and Rails versions: - Ruby: 3.2, 3.3, 3.4 (drop 3.1 which is EOL) - Rails: 7.2, 8.0, edge (drop 7.0 and 7.1 which are EOL) Update GitHub Actions to unpinned major versions: - actions/checkout@v4 (was pinned to v1.2.0 SHA) - ruby/setup-ruby@v1 (was pinned to v1.238.0 SHA) Bump minimum requirements: - required_ruby_version >= 3.2.0 (was >= 3.0.0) - activesupport >= 7.2 (was >= 5.2) Bump gem version to 3.3.0.
ntn
force-pushed
the
update-ci-and-version
branch
from
a380335 to
95c72f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the CI matrix and dependency requirements to currently supported versions, and bumps the gem version to 3.3.0.
CI matrix
Ruby:
Rails:
GitHub Actions
actions/checkout: pinned SHA (v1.2.0) to@v4ruby/setup-ruby: pinned SHA (v1.238.0) to@v1Dependency requirements
required_ruby_version:>= 3.0.0to>= 3.2.0activesupport:>= 5.2to>= 7.2tapioca:>= 0.17.0(already set by Fix CI: pin tapioca >= 0.17.0 #187)Version bump
3.2.1 to 3.3.0 (minor bump for the dependency floor changes).