Skip to content

Conversation

@amomchilov
Copy link
Contributor

@amomchilov amomchilov commented Jan 5, 2026

Motivation

  1. Fix incorrect shim for URI::Source#fragment and URI::Source#gem_name
  2. Remove untyped call to alias_method
  3. Add missing / in to_s output (mainly for debugging, not used in RubyLSP)
  4. Sync this file with its copy in Tapioca (see also: Sync URI::Source with RubyLSP tapioca#2475)

Copy link
Contributor Author


How to use the Graphite Merge Queue

Add the label graphite-merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@amomchilov amomchilov changed the title Rearrange URI::Source shims Sync URI::Source with Tapioca Jan 5, 2026
@amomchilov amomchilov requested a review from vinistock January 5, 2026 22:57
@amomchilov amomchilov added enhancement New feature or request found-by-sorbet Bugs in our code found by Sorbet's static analysis labels Jan 5, 2026
@amomchilov amomchilov requested a review from Morriar January 5, 2026 22:58
@amomchilov amomchilov marked this pull request as ready for review January 5, 2026 22:58
@amomchilov amomchilov requested a review from a team as a code owner January 5, 2026 22:58
@amomchilov amomchilov added the server This pull request should be included in the server gem's release notes label Jan 6, 2026
amomchilov and others added 5 commits January 6, 2026 13:10
Co-authored-by: Vinicius Stock <vinicius.stock@shopify.com>
Co-authored-by: Vinicius Stock <vinicius.stock@shopify.com>
@amomchilov amomchilov requested a review from vinistock January 6, 2026 18:47
@amomchilov amomchilov self-assigned this Jan 6, 2026
@amomchilov amomchilov enabled auto-merge January 6, 2026 19:29
@amomchilov amomchilov merged commit 3d76aa4 into main Jan 6, 2026
38 checks passed
@amomchilov amomchilov deleted the Alex/sync-URI branch January 6, 2026 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request found-by-sorbet Bugs in our code found by Sorbet's static analysis server This pull request should be included in the server gem's release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants