Merged
Conversation
vinistock
commented
Jan 8, 2026
| LexicalScope(DefinitionId), | ||
| /// An owner entry that will be associated with all members encountered, but will not produce a new lexical scope | ||
| /// (e.g.: Module.new or Class.new) | ||
| #[allow(dead_code)] |
Member
Author
There was a problem hiding this comment.
This is dead just until the work on the other PR is complete.
Morriar
approved these changes
Jan 8, 2026
vinistock
force-pushed
the
01-08-add_nesting_enum_for_indexer
branch
from
dfc8a2f to
81d47f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extracts just the new
Nestingenum portion of #402, to make it a bit easier to handle the existing conflicts with main.Basically, the
definitions_stackbecomes anesting_stack, where we can store the IDs with a bit of differentiation and perform the right behaviour:classormodulekeywords get used, which produces a new lexical scope that binds constants and class variablesClass.new)