Merged
Conversation
Morriar
reviewed
Jan 8, 2026
Comment on lines
-321
to
+329
| pub fn add_member(&mut self, member_id: DefinitionId) { | ||
| self.members.push(member_id); | ||
| } | ||
|
|
||
| #[must_use] | ||
| pub fn mixins(&self) -> &[Mixin] { | ||
| &self.mixins | ||
| } | ||
|
|
||
| pub fn add_member(&mut self, member_id: DefinitionId) { | ||
| self.members.push(member_id); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Can we preserve the order so add_member comes right after members?
Member
There was a problem hiding this comment.
Oops I didn't know auto-merge was enabled
Member
Author
There was a problem hiding this comment.
add_member does come after members. The diff on GitHub is weird, all I did was move the entire impl block as is.
st0012
approved these changes
Jan 8, 2026
Member
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another extraction to simplify #402
The impl block for
ClassDefinitionwas the only one that was not next to its struct. This PR just moves it next to it.