Conversation
This was referenced Mar 2, 2026
Member
Author
9431446 to
8f9a3c1
Compare
5414794 to
cc10553
Compare
2d6e58d to
aecab13
Compare
cc10553 to
14702a0
Compare
alexcrocha
approved these changes
Mar 4, 2026
775ee22 to
517c495
Compare
aecab13 to
383aa1e
Compare
383aa1e to
da688ab
Compare
da688ab to
25ac4f0
Compare
Member
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

We were incorrectly creating singleton classes for non promotable constants. For example:
Would result in
CONST::<CONST>existing, which is not correct. This PR fixes that.