Skip to content

Avoid creating singleton classes for non-namespace targets#623

Merged
vinistock merged 1 commit intomainfrom
03-02-avoid_creating_singleton_classes_for_non-namespace_targets
Mar 4, 2026
Merged

Avoid creating singleton classes for non-namespace targets#623
vinistock merged 1 commit intomainfrom
03-02-avoid_creating_singleton_classes_for_non-namespace_targets

Conversation

@vinistock
Copy link
Member

@vinistock vinistock commented Mar 2, 2026

We were incorrectly creating singleton classes for non promotable constants. For example:

CONST = 1

class << CONST
end

Would result in CONST::<CONST> existing, which is not correct. This PR fixes that.

@vinistock vinistock self-assigned this Mar 2, 2026
@vinistock vinistock added the bugfix A change that fixes an existing bug label Mar 2, 2026 — with Graphite App
@vinistock vinistock marked this pull request as ready for review March 2, 2026 19:09
@vinistock vinistock requested a review from a team as a code owner March 2, 2026 19:09
@vinistock vinistock force-pushed the 03-02-avoid_creating_singleton_classes_for_non-namespace_targets branch from 9431446 to 8f9a3c1 Compare March 2, 2026 19:12
@vinistock vinistock force-pushed the 03-02-auto_promote_when_creating_constants_inside_namespace branch 2 times, most recently from 5414794 to cc10553 Compare March 2, 2026 19:59
@vinistock vinistock force-pushed the 03-02-avoid_creating_singleton_classes_for_non-namespace_targets branch 2 times, most recently from 2d6e58d to aecab13 Compare March 4, 2026 14:49
@vinistock vinistock force-pushed the 03-02-auto_promote_when_creating_constants_inside_namespace branch from cc10553 to 14702a0 Compare March 4, 2026 14:49
@vinistock vinistock force-pushed the 03-02-auto_promote_when_creating_constants_inside_namespace branch 2 times, most recently from 775ee22 to 517c495 Compare March 4, 2026 20:45
@vinistock vinistock force-pushed the 03-02-avoid_creating_singleton_classes_for_non-namespace_targets branch from aecab13 to 383aa1e Compare March 4, 2026 20:45
@vinistock vinistock changed the base branch from 03-02-auto_promote_when_creating_constants_inside_namespace to graphite-base/623 March 4, 2026 20:52
@vinistock vinistock force-pushed the 03-02-avoid_creating_singleton_classes_for_non-namespace_targets branch from 383aa1e to da688ab Compare March 4, 2026 20:54
@graphite-app graphite-app bot changed the base branch from graphite-base/623 to main March 4, 2026 20:54
@vinistock vinistock force-pushed the 03-02-avoid_creating_singleton_classes_for_non-namespace_targets branch from da688ab to 25ac4f0 Compare March 4, 2026 20:55
@vinistock vinistock merged commit e1b377c into main Mar 4, 2026
33 checks passed
Copy link
Member Author

Merge activity

@vinistock vinistock deleted the 03-02-avoid_creating_singleton_classes_for_non-namespace_targets branch March 4, 2026 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix A change that fixes an existing bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants