Merged
Conversation
vinistock
added
the
bugfix
Graphite App
vinistock
force-pushed
the
03-17-ensure_we_index_new_call_receivers
branch
from
9f34cb5 to
59ead1f
Compare
alexcrocha
approved these changes
Mar 17, 2026
st0012
approved these changes
Mar 17, 2026
| if method_receiver.is_none() | ||
| && let Some(receiver) = node.receiver() | ||
| { | ||
| self.visit(&receiver); |
Member
There was a problem hiding this comment.
Is it for indexing foo in foo.bar?
Member
Author
There was a problem hiding this comment.
Yes, correct. If the method receiver is not a constant, we still want to visit to ensure that any other relevant indexing data is collected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because we process
newin a special way, we weren't correctly indexing the singleton receiver or counting them as method references.This PR fixes those.