Organize ruby_indexer tests into nested submodules#672
Open
alexcrocha wants to merge 5 commits into03-13-extract_class_and_module_tests_from_monolithic_mod_testsfrom
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
alexcrocha
changed the title
alexcrocha
changed the title
alexcrocha
added
the
chore
Member
|
Why nested instead of another top level test module? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #649.
This PR extracts and groups more tests into nested submodules: constants, methods, singleton classes, visibility, and attr accessors.
We also move
assert_parameter!intomethod_testssince nothing else uses it.I am splitting this refactor into multiple commits and PRs to catch and address any issues more easily. Please expect about 2 more PRs for
ruby_indexer.rs.Tip: the diff looks noisy due to indentation changes from nesting. Toggle "Hide whitespace" in GitHub's diff settings for a cleaner review.