Conversation
The previous public-release prep removed neocache because the upstream
crate at github.com/Shopify/neocache was still a private repository,
which broke `cargo build` and `cargo clippy --locked` on any clone
without Shopify git credentials (including public CI runners).
Shopify/neocache is now scheduled to be made public, so restore:
- The git dependency in Cargo.toml (pinned to commit
3c87b8fde4fab6eb3e9285c05df5ab8ae0cf498c, with the same
"bump deliberately when re-baselining" comment as before).
- The matching package stanza and cache-bench dep entry in
Cargo.lock (no other pin moved).
- src/caches/neocache.rs (S3-FIFO + DashMap benchmark, with the
same warmup/measurement structure as the other cache modules).
- The `pub mod neocache;` declaration in src/caches/mod.rs.
- The "neocache" entry in ALL_CACHES and the corresponding
dispatch arm in src/main.rs.
- The neocache mentions in --help and --info output (AVAILABLE
CACHES list and the `-c moka,neocache` example).
- The \[neocache\] row in the README comparison table and the
`--caches moka,quick_cache,neocache` example. Removed the
"Note on neocache" explainer block that documented the
temporary absence.
CI on this branch will fail with `failed to authenticate when
downloading repository` until Shopify/neocache is actually public;
merge after that flip.
Local verification (with credentials):
- cargo fmt --check
- cargo clippy --all-targets --locked -- -D warnings
- cargo build --locked
- cargo test --locked (20 passed)
- --help and --info output show neocache in the cache list
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores the neocache benchmark module, git dependency, lockfile entries, ALL_CACHES/dispatch entries, README table row, and help/info text that were removed during the public-release prep.
Shopify/neocacheis being made public soon — once that happens, the auth failure that originally motivated removing this dep will resolve itself and CI onmainwill go green again.Known: CI will fail on this PR until
Shopify/neocacheis publicThe exact error from the original CI run will recur:
This is expected and acknowledged by the merger. Bypassing required workflow check via admin merge.
Local verification (with Shopify git credentials)
cargo fmt --check✅cargo clippy --all-targets --locked -- -D warnings✅cargo build --locked✅cargo test --locked✅ (20 passed)cargo run -- --helpand--infoshow neocache in the cache list ✅Files changed
Cargo.toml— restore neocache git depCargo.lock— restore neocache package stanza + cache-bench dep entry (no other pin moved)src/caches/neocache.rs— restored (new file, S3-FIFO + DashMap benchmark)src/caches/mod.rs— restorepub mod neocache;src/main.rs— restore ALL_CACHES entry, dispatch arm, help/info textREADME.md— restore comparison-table row and example; remove "Note on neocache" explainer block