Replace deprecated --frozen flag with bundle config set frozen true
#1448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+48
to
+50
| def bundle_config_frozen | ||
| 'bundle config set --local frozen true' | ||
| end |
Contributor
There was a problem hiding this comment.
🤔 Do we also need to have bundle config set --local frozen false explicitly (e.g. if we're using cached context and the config changes from one commit to the other)?
Contributor
Author
There was a problem hiding this comment.
I don't think so, Shipit creates a fresh working directory for each task execution so there should be no risk of config being shared
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
BundlerDiscovery#bundle_installto stop appending the--frozenflag to thebundle installcommand.bundle config set --local frozen truebeforebundle installwhen aGemfile.lockis present.Context
The
--frozenflag was deprecated and subsequently removed in Bundler 2.3+. Attempting to use it results in an error:This change restores compatibility with modern Bundler versions while preserving the intended "frozen" behaviour for deployments.