Create mocks for the entire Admin extension API#3914
Open
kumar303 wants to merge 1 commit into02-12-create_mocks_for_the_entire_customer_account_extension_apifrom
Open
Conversation
This was referenced Feb 12, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_customer_account_extension_api
branch
from
27fe3a8 to
8fccf50
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_admin_extension_api
branch
from
4c628d8 to
b85e478
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_customer_account_extension_api
branch
from
8fccf50 to
b6b83e9
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_admin_extension_api
branch
from
b85e478 to
1d61583
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_customer_account_extension_api
branch
from
b6b83e9 to
574013a
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_admin_extension_api
branch
from
1d61583 to
13b040e
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_customer_account_extension_api
branch
from
574013a to
bab7729
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_admin_extension_api
branch
2 times, most recently
from
381b4b0 to
7d9c01d
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_customer_account_extension_api
branch
from
bab7729 to
a303042
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_admin_extension_api
branch
2 times, most recently
from
2b2e29f to
51d4649
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_customer_account_extension_api
branch
2 times, most recently
from
2db9df6 to
6e15cd7
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_admin_extension_api
branch
from
51d4649 to
05ae0aa
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_customer_account_extension_api
branch
from
6e15cd7 to
83b81e0
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_admin_extension_api
branch
2 times, most recently
from
824bdde to
7fe1043
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_customer_account_extension_api
branch
from
83b81e0 to
69f7238
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_admin_extension_api
branch
from
7fe1043 to
ebd1e09
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_customer_account_extension_api
branch
from
69f7238 to
bb90420
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_admin_extension_api
branch
from
ebd1e09 to
da03983
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_customer_account_extension_api
branch
2 times, most recently
from
9707ec1 to
2b029e3
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_admin_extension_api
branch
from
da03983 to
a2036e0
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_customer_account_extension_api
branch
from
0ad6fc2 to
bbae459
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_admin_extension_api
branch
3 times, most recently
from
f818e9e to
2c24129
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_customer_account_extension_api
branch
from
4fb5962 to
2a4b2ee
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_admin_extension_api
branch
3 times, most recently
from
30baf2f to
da9aa46
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_customer_account_extension_api
branch
2 times, most recently
from
525403d to
6e71146
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_admin_extension_api
branch
2 times, most recently
from
0dbd881 to
a73d9a3
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_customer_account_extension_api
branch
2 times, most recently
from
72c73f2 to
f40aec8
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_admin_extension_api
branch
2 times, most recently
from
c1fd817 to
472f137
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_customer_account_extension_api
branch
2 times, most recently
from
c54d277 to
ce20b48
Compare
Contributor
Author
|
/snapit |
7 similar comments
Contributor
Author
|
/snapit |
Contributor
Author
|
/snapit |
Contributor
Author
|
/snapit |
Contributor
Author
|
/snapit |
Contributor
Author
|
/snapit |
Contributor
Author
|
/snapit |
Contributor
Author
|
/snapit |
vividviolet
reviewed
Mar 9, 2026
| extensions/*/build | ||
| extensions/*/dist | ||
|
|
||
| # lock files |
Contributor
Author
There was a problem hiding this comment.
wouldn't we want to keep them in case someone runs an example with shopify app dev to try it out? I was doing that during development.
vividviolet
reviewed
Mar 9, 2026
Member
vividviolet
left a comment
vividviolet
left a comment
There was a problem hiding this comment.
Thanks for doing this! I have a few questions
examples/testing/admin-testing-example/extensions/admin-testing-example/package.json
Outdated
Show resolved
Hide resolved
examples/testing/admin-testing-example/extensions/admin-testing-example/shopify.extension.toml
Outdated
Show resolved
Hide resolved
examples/testing/admin-testing-example/extensions/admin-testing-example/src/SelectionAction.jsx
Outdated
Show resolved
Hide resolved
...testing/admin-testing-example/extensions/admin-testing-example/tests/SelectionAction.test.ts
Outdated
Show resolved
Hide resolved
examples/testing/admin-testing-example/extensions/admin-testing-example/src/BlockExtension.jsx
Outdated
Show resolved
Hide resolved
vividviolet
reviewed
Mar 10, 2026
Member
vividviolet
left a comment
vividviolet
left a comment
There was a problem hiding this comment.
Looks great - just a small fix for the test extension 🙏
examples/testing/admin-testing-example/extensions/admin-testing-example/src/SelectionAction.jsx
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #3899 that adds a complete, type-safe mock of the Admin extension API
👁️ How to review this PR