Skip to content

add discount index targets#4078

Merged
jonathanhamel4 merged 1 commit into2026-04-rcfrom
jh_discount-target-ui-extension
Mar 10, 2026
Merged

add discount index targets#4078
jonathanhamel4 merged 1 commit into2026-04-rcfrom
jh_discount-target-ui-extension

Conversation

@jonathanhamel4
Copy link
Contributor

@jonathanhamel4 jonathanhamel4 commented Mar 10, 2026

Background

Adds discount index bulk action targets that are already added in Core and about to be shipped in Admin under a beta.

Do I need to add to other versions? Link and UI Extensions for actions aren't versioned the same way

Solution

Allows to use discount-index.selection-action.should-render and discount-index.selection-action.render extension points.

@jonathanhamel4 jonathanhamel4 force-pushed the jh_discount-target-ui-extension branch from c5c6104 to 5c1f004 Compare March 10, 2026 13:56
@jonathanhamel4
Copy link
Contributor Author

jonathanhamel4 commented Mar 10, 2026

@mcvinci I want to add a new target that is already supported in core. Do I need to add the generated docs or are they pulled automatically? Pinged you since the blame of those files pointed to you generating them. When I run like yarn docs:admin 2026-04, there seem to be a lot of noise in those files.

@jonathanhamel4 jonathanhamel4 force-pushed the jh_discount-target-ui-extension branch from 5c1f004 to 21566b3 Compare March 10, 2026 14:25
@mcvinci
Copy link
Contributor

mcvinci commented Mar 10, 2026

@mcvinci I want to add a new target that is already supported in core. Do I need to add the generated docs or are they pulled automatically? Pinged you since the blame of those files pointed to you generating them. When I run like yarn docs:admin 2026-04, there seem to be a lot of noise in those files.

@majd-shopify Could you confirm whether the generated docs need to be committed? I think committing the generated files is primarily for tophatting / previewing purposes, but not sure if they need to be committed to get pulled automatically into Shopify.dev.

@jonathanhamel4 On a related note, we're aiming to release a big refresh to the App Home and Admin UI extensions docs by end of week, so we're going to be regenerating the docs quite frequently over the next while.

You can see what things will look like here:

@jonathanhamel4 jonathanhamel4 merged commit 072a537 into 2026-04-rc Mar 10, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants