Conversation
c5c6104 to
5c1f004
Compare
|
@mcvinci I want to add a new target that is already supported in core. Do I need to add the generated docs or are they pulled automatically? Pinged you since the blame of those files pointed to you generating them. When I run like |
5c1f004 to
21566b3
Compare
@majd-shopify Could you confirm whether the generated docs need to be committed? I think committing the generated files is primarily for tophatting / previewing purposes, but not sure if they need to be committed to get pulled automatically into Shopify.dev. @jonathanhamel4 On a related note, we're aiming to release a big refresh to the App Home and Admin UI extensions docs by end of week, so we're going to be regenerating the docs quite frequently over the next while. You can see what things will look like here: |
Background
Adds discount index bulk action targets that are already added in Core and about to be shipped in Admin under a beta.
Do I need to add to other versions? Link and UI Extensions for actions aren't versioned the same way
Solution
Allows to use
discount-index.selection-action.should-renderanddiscount-index.selection-action.renderextension points.