changes from the thread direct branch 07/27 - #239
Conversation
PR SummaryMedium Risk Overview When an energy scan must wait on the radio, the PAL queues the scan via Reviewed by Cursor Bugbot for commit 4575df0. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
I have read the CLA Document and I hereby sign the CLA behalf on myself, e-mail: example@example.com or I have read the CLA Document and I hereby sign the CLA behalf of my company, e-mail: example@example.com Signature is valid for 6 months. This bot will be retriggered when the Contributor License Agreement comment has been provided. Posted by the CLA Assistant Lite bot. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
Reviewed by Cursor Bugbot for commit 4575df0. Configure here.
|
|
||
| offset += | ||
| sli_ot_radio_direct_generate_enh_ack_ie_data(aInstance, aReceivedFrame, sAckIeData + offset, available); | ||
| } |
There was a problem hiding this comment.
Listener Enh-ACK wait missing
Medium Severity
Listener support was added for Thread Direct Enh-ACK IE buffer sizing and generateAckIeData, but the receive-side spin-poll that waits for Challenge LTV bytes before building the Enh-ACK stays under OPENTHREAD_CONFIG_THREAD_DIRECT_WAKE_INITIATOR_ENABLE only. In listener-only builds, sli_ot_radio_direct_generate_enh_ack_ie_data can run against incomplete early frame data after DATA_REQUEST_COMMAND, so Challenge echo or related TD Enh-ACK content can be wrong or missing.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 4575df0. Configure here.


No description provided.