Skip to content

changes from the thread direct branch 07/27 - #239

Open
Suvesh Pratapa (suveshpratapa) wants to merge 1 commit into
SiliconLabsSoftware:feature/thread-directfrom
suveshpratapa:wip/testing-thread-direct
Open

changes from the thread direct branch 07/27#239
Suvesh Pratapa (suveshpratapa) wants to merge 1 commit into
SiliconLabsSoftware:feature/thread-directfrom
suveshpratapa:wip/testing-thread-direct

Conversation

@suveshpratapa

Copy link
Copy Markdown

No description provided.

@suveshpratapa
Suvesh Pratapa (suveshpratapa) requested a review from a team as a code owner July 27, 2026 18:20
@cursor

cursor Bot commented Jul 27, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Changes timing-sensitive MAC transmit scheduling and enhanced-ACK IE paths for Thread Direct; energy-scan deferral alters multi-instance busy behavior but is localized to the PAL.

Overview
Thread Direct on EFR32 now treats wake listener the same as the wake initiator for enhanced-ACK IE buffering/generation, and keys scheduled TX / SCA LTV header updates off frames that carry an SCA LTV (otMacFrameHasThreadDirectScaLtv) instead of only TD link commands.

When an energy scan must wait on the radio, the PAL queues the scan via sli_ot_radio_instance_energy_scan_defer rather than failing with OT_ERROR_BUSY. Minor cleanups: portable RAIL event log formatting, inlined RAIL init assert, and dropping an explicit mRadioType assignment on generated enhanced ACKs.

Reviewed by Cursor Bugbot for commit 4575df0. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

Copy link
Copy Markdown
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. For privacy information, see our Privacy Notice. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA behalf on myself, e-mail: example@example.com

or

I have read the CLA Document and I hereby sign the CLA behalf of my company, e-mail: example@example.com

Signature is valid for 6 months.


This bot will be retriggered when the Contributor License Agreement comment has been provided. Posted by the CLA Assistant Lite bot.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

Reviewed by Cursor Bugbot for commit 4575df0. Configure here.


offset +=
sli_ot_radio_direct_generate_enh_ack_ie_data(aInstance, aReceivedFrame, sAckIeData + offset, available);
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Listener Enh-ACK wait missing

Medium Severity

Listener support was added for Thread Direct Enh-ACK IE buffer sizing and generateAckIeData, but the receive-side spin-poll that waits for Challenge LTV bytes before building the Enh-ACK stays under OPENTHREAD_CONFIG_THREAD_DIRECT_WAKE_INITIATOR_ENABLE only. In listener-only builds, sli_ot_radio_direct_generate_enh_ack_ie_data can run against incomplete early frame data after DATA_REQUEST_COMMAND, so Challenge echo or related TD Enh-ACK content can be wrong or missing.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 4575df0. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant