Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ Another line of really good description
```

## Pull Request Guideline
Okay you finished your work committed all your changes to your branch. Time to create a pull request.
Okay, you finished your work and committed all your changes to your branch. Time to create a pull request.
Refer to the general pull request [guideline](https://opensource.guide/how-to-contribute/#opening-a-pull-request) from GitHub.
What to consider when raising a Pull Request:
1. **Pull Request Naming**
Expand All @@ -124,10 +124,8 @@ What to consider when raising a Pull Request:
GitHub assigns reviewers based on the [CODEOWNERS](CODEOWNERS) file.
Add more reviewers if needed. Do not remove reviewers from the PR. Ask the repository owner for updates to the code owners.
4. **Evaluate the Action Workflow Results**
The following workflows are included in every repository:
- **[Coding Convention Check](workflows/00-Check-Code-Convention.yml)**: Analyzes the code formatting and fails if any rules are broken.
- **[Firmware Build](workflows/02-Build-Firmware.yml)**: Builds the firmware inside the [Dockerfile](../Dockerfile).
- **[Secret Scanner](workflows/04-TruffleHog-Security-Scan.yml)**: Runs the TruffleHog security scanner to look for API keys and committed secrets.
The following workflows are included in this repository:
- **[Unit tests and Coverage Report](workflows/unittest-and-coverage.yml)**: Runs the unit tests and generates the coverage report. Total coverage should remain in the high 90s.

### As a Reviewer

Expand Down
60 changes: 0 additions & 60 deletions .github/rulesets/Silabs-basic-public-ruleset.json

This file was deleted.

55 changes: 0 additions & 55 deletions .github/rulesets/Silabs-basic-ruleset-internal.json

This file was deleted.

8 changes: 8 additions & 0 deletions .github/workflows/unittest-and-coverage.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,14 @@
name: Unit tests and Coverage Report

on:
push:
branches:
- main
- develop/**
pull_request:
branches:
- main
- develop/**
workflow_dispatch:

permissions:
Expand Down
Loading