Fixing domain-specific conductances for EP#506
Merged
ktbolt merged 7 commits intoSimVascular:mainfrom Feb 27, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #506 +/- ##
==========================================
+ Coverage 67.82% 67.85% +0.02%
==========================================
Files 168 168
Lines 32744 32749 +5
Branches 5751 5748 -3
==========================================
+ Hits 22210 22221 +11
+ Misses 10397 10391 -6
Partials 137 137 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kko27
reviewed
Feb 12, 2026
kko27
reviewed
Feb 12, 2026
Contributor
kko27
left a comment
There was a problem hiding this comment.
Wow. I realized now that there were a lot of places where the cep_mod was incorrectly used. I think this all looks correct to me...
ktbolt
reviewed
Feb 12, 2026
ktbolt
reviewed
Feb 12, 2026
ktbolt
reviewed
Feb 12, 2026
ktbolt
reviewed
Feb 12, 2026
Collaborator
ktbolt
reviewed
Feb 13, 2026
ktbolt
reviewed
Feb 13, 2026
ktbolt
approved these changes
Feb 27, 2026
Collaborator
|
@kko27 Is this PR ready to be merged ? |
kko27
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current situation
Resolves #504
Code of Conduct & Contributing Guidelines