Skip to content

Fixing domain-specific conductances for EP#506

Merged
ktbolt merged 7 commits intoSimVascular:mainfrom
javijv4:dev_#504
Feb 27, 2026
Merged

Fixing domain-specific conductances for EP#506
ktbolt merged 7 commits intoSimVascular:mainfrom
javijv4:dev_#504

Conversation

@javijv4
Copy link
Contributor

@javijv4 javijv4 commented Feb 12, 2026

Current situation

Resolves #504

Code of Conduct & Contributing Guidelines

@javijv4 javijv4 requested review from kko27 and ktbolt February 12, 2026 03:05
@codecov
Copy link

codecov bot commented Feb 12, 2026

Codecov Report

❌ Patch coverage is 58.18182% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.85%. Comparing base (bc36c39) to head (773ff5b).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
Code/Source/solver/cep_ion.cpp 36.11% 23 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #506      +/-   ##
==========================================
+ Coverage   67.82%   67.85%   +0.02%     
==========================================
  Files         168      168              
  Lines       32744    32749       +5     
  Branches     5751     5748       -3     
==========================================
+ Hits        22210    22221      +11     
+ Misses      10397    10391       -6     
  Partials      137      137              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@kko27 kko27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow. I realized now that there were a lot of places where the cep_mod was incorrectly used. I think this all looks correct to me...

@ktbolt
Copy link
Collaborator

ktbolt commented Feb 12, 2026

@javijv4 Be sure to update the Issue #504 with a brief description about how you fixed the Issue.

@ktbolt
Copy link
Collaborator

ktbolt commented Feb 27, 2026

@kko27 Is this PR ready to be merged ?

@ktbolt ktbolt merged commit 28be387 into SimVascular:main Feb 27, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Domain specific conductances are not being used in EP

3 participants