Correction viscosity term in ChamberSphere block#217
Merged
KatrinKoesler merged 6 commits intoSimVascular:masterfrom Feb 27, 2026
Merged
Correction viscosity term in ChamberSphere block#217KatrinKoesler merged 6 commits intoSimVascular:masterfrom
KatrinKoesler merged 6 commits intoSimVascular:masterfrom
Conversation
…ulations based on Caruel et al. 2013
…viscosity part in the equation)
…er into chamber_sphere
mrp089
approved these changes
Feb 26, 2026
Member
|
@KatrinKoesler, nicely done! Can you add a screenshot of your before/after comparison for reference? Thanks! |
Collaborator
Author
Plotting a pv-loop and pressures/volume/in- and outflow over time in a cardiac cycle |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correction viscosity term in ChamberSphere block
Current situation
This addresses the problem highlighted in #216. Calculations indicated that the implementation of the viscosity term might previously have been incorrect. Further calculations have shown this is the case.
Release Notes
The viscosity term has been updated from
2 * eta * dCG * (1 - 2 * C**(-6))toeta * dCG * (1 + 2 * C**(-6)). The test file for the ChamberSphere test case has been adjusted according to the new outputs. The overall behavior has not changed significantly due to this change, which is expected since the term has a much lower contribution than the elastic strain energy term.Documentation
Has been changed accordingly with the new formulation of the viscosity term.
Testing
Test case has been adjusted accordingly, all tests run.
Code of Conduct & Contributing Guidelines