Implement /api/derive/session/progress call#35
Conversation
|
Hi @aspekt112 , thanks a lot for your contribution! We will give it a look hopefully soon. |
|
@dillu24 Hello! How soon can you review these changes? |
Added system/account
|
Later this week hopefully |
|
@aspekt112 - Sorry for the delay, will start reviewing now. |
dillu24
left a comment
dillu24
left a comment
There was a problem hiding this comment.
Good Work! Require only few minor changes:
- Change the endpoint description as described in one of the threads.
- Add the following entry to
doc/CHANGELOG.md'sUnreleased Section:
- Added
session/progress. This returns information about the current session.
| | `/api/custom/getSlashAmount` | `websocket`, `account_address` | `block_hash` | The `balance slashed` (if any) of the specified `account address` in the specified `block hash`, or in the latest block if the block hash is not specified | | ||
| | **Derive** | | | | | ||
| | `/api/derive/staking/validators` | `websocket` | None | `nextElected` - List of `validators` which will be active in the `next session` and `validators` - List of `validators` which are currently active | | ||
| | `/api/derive/session/progress` | `websocket` | None | retrieves all the `session` and `era` query and calculates specific values on it as the length of the session and eras | |
There was a problem hiding this comment.
Change the description to Retrieves information about the current session
There was a problem hiding this comment.
Also, same as my other comment, kindly put this above /api/derive/staking/validators
DanielMagro97
left a comment
DanielMagro97
left a comment
There was a problem hiding this comment.
Just a few minor comments for rewording and reordering of functions
| params={'websocket': websocket}) | ||
| print(r.text) | ||
|
|
||
| print('/api/derive/session/progress') |
There was a problem hiding this comment.
Kindly move this before /api/derive/staking/validators, to keep things in alphabetical order
| | `/api/custom/getSlashAmount` | `websocket`, `account_address` | `block_hash` | The `balance slashed` (if any) of the specified `account address` in the specified `block hash`, or in the latest block if the block hash is not specified | | ||
| | **Derive** | | | | | ||
| | `/api/derive/staking/validators` | `websocket` | None | `nextElected` - List of `validators` which will be active in the `next session` and `validators` - List of `validators` which are currently active | | ||
| | `/api/derive/session/progress` | `websocket` | None | retrieves all the `session` and `era` query and calculates specific values on it as the length of the session and eras | |
There was a problem hiding this comment.
Also, same as my other comment, kindly put this above /api/derive/staking/validators
| | `/api/query/staking/payee` | `websocket`, `account_id` | None | Reward destination address assigned to the stash with the specified `account_id`. Returns json with different keys depending on the type of reward destination: `staked: null` - when reward destination is a stash, `controller: addr` - when reward destination is a controller, and `result: addr` when reward destination is any other address. | | ||
| | `/api/query/staking/unappliedSlashes` | `websocket` | `era_index` | List of slashed validators (unapplied) in the specified era, or the current era if an era index is not specified. | | ||
| | `/api/query/staking/validators` | `websocket`, `account_id` | Preferences of the validator whose stash is the specified `account_id` (validator commission and blocked status). | | ||
| | `/api/query/system/account` | `websocket`, `account_id` | None | The full account information for a particular account ID | |
There was a problem hiding this comment.
The full account information for the specified account_id
| ); | ||
| } | ||
|
|
||
| // Session |
There was a problem hiding this comment.
Same as before, kindly put Session before Staking
| } catch (e) { | ||
| return {'error': e.toString()}; | ||
| } | ||
| // Session |
| } | ||
| }); | ||
|
|
||
| // Session |
There was a problem hiding this comment.
Again kindly put this before the Derive Staking one to preserve the alphabetical order
|
@dillu24 @DanielMagro97 can you review fixes? |
|
@aspekt112 - Sorry for the delay, we will be reviewing this week for sure. |
|
@dillu24 @DanielMagro97 Please review another commit. Last runtime upgrade made major API changes |
|
@aspekt112 .. Waiting for #36 to be merged. Once it is merged please merge from master into this branch so that the latest changes are reflected. |
4 participants
This API call allow us to obtain much more info about current session and era: