Open
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes a crash caused by oversized navigation arguments/saved-state bundles when caller apps send very large metadata in the launch Intent, by no longer passing Intent data through NavArgs and instead reading it directly from the hosting Activity.
Changes:
- Removed
requestAction/requestParamsnavigation arguments from the orchestration graph. - Stopped initializing the orchestration graph with fragment args in
OrchestratorActivity. - Updated
OrchestratorFragmentto readIntent.actionandIntent.extrasfrom the activity at runtime (and populate caller-package info there).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| feature/orchestrator/src/main/res/navigation/graph_orchestration.xml | Removes orchestration fragment args so large metadata isn’t duplicated into fragment arguments. |
| feature/orchestrator/src/main/java/com/simprints/feature/orchestrator/OrchestratorFragment.kt | Reads action/extras from Activity.intent and sets caller package info without using NavArgs. |
| feature/orchestrator/src/main/java/com/simprints/feature/orchestrator/OrchestratorActivity.kt | Initializes nav graph without passing Intent data as fragment args. |
You can also share your feedback on Copilot code review. Take the survey.
feature/orchestrator/src/main/java/com/simprints/feature/orchestrator/OrchestratorFragment.kt
Outdated
Show resolved
Hide resolved
…d multiple copies of arguments in associated VMs
edd362c to
3c15faf
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



JIRA ticket
Will be released in: 2026.2.0
Root cause analysis (for bugfixes only)
First known affected version: at least since the last navigation refactoring
Notable changes
Testing guidance
Additional work checklist