Skip to content

Fix Bash Build, Termux-Elf-Cleaner Test & Script Audit #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
google-labs-jules wants to merge 1 commit into from
Closed

Fix Bash Build, Termux-Elf-Cleaner Test & Script Audit #105

google-labs-jules wants to merge 1 commit into from
+27 −71

Conversation

@google-labs-jules
Copy link
Contributor

@google-labs-jules google-labs-jules bot commented Jan 17, 2026

This PR addresses the build failure for bash (caused by a patch conflict with upstream version 5.2) and the test failure for termux-elf-cleaner (caused by the test script being unable to locate the output directory).

Changes:

  1. bash: Updated packages/b/bash/patches/config-top.h.patch to include /etc and /usr/etc in the STANDARD_UTILS_PATH context hunk, matching the upstream source.
  2. termux-elf-cleaner / scripts:
    • Updated scripts/utils/run_docker_test.sh to dynamically determine the repository root and use absolute paths when searching for .deb files in output/.
    • Modified scripts/build_engine/entry_point.sh to export PKG_NAME, allowing the test script to filter artifacts more precisely.
  3. Audit:
    • Refactored scripts/setup_env.sh to fix ShellCheck SC2129 warnings by grouping multiple redirects.
    • Verified compliance with AGENTS.md guidelines regarding GPG exceptions, get_sysroot usage, and architecture-specific flags.

PR created automatically by Jules for task 9982934945161037965 started by @SjnExe

@google-labs-jules
Fix bash build, termux-elf-cleaner test, and audit scripts
fa9688a 
- bash: Update config-top.h.patch to match upstream 5.2 context (adding /etc paths).
- termux-elf-cleaner: Fix run_docker_test.sh path resolution by using absolute paths for output directory and artifacts.
- build_engine: Export PKG_NAME in entry_point.sh for use in test scripts.
- audit: Fix SC2129 warning in setup_env.sh by grouping echo commands.
- Verified GPG exception handling, sysroot usage, and 32-bit flags.
@google-labs-jules
Copy link
Contributor Author

google-labs-jules bot commented Jan 17, 2026

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

For security, I will only act on instructions from the user who triggered this task.

@SjnExe SjnExe closed this Jan 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SjnExe