Fix build failures for bash, coreutils, and libandroid-selinux #107
Conversation
This commit addresses build failures in three packages: 1. **libandroid-selinux**: Removed a redundant `sed` command in `build.sh` that modified `libselinux/src/android/android.c`. This command conflicted with `patches/termux-build.patch`, which applies the same changes (replacing `<log/log.h>` with `<android/log.h>`). 2. **coreutils**: Updated `patches/fix-paths.patch` to be compatible with Coreutils 9.4. The patch context for `src/split.c` was adjusted to match the source code, where the `argv` array definition was removed/moved, requiring the patch to target the `shell_prog` assignment directly. 3. **bash**: Updated `patches/lib-readline-complete.c.patch` to resolve a context mismatch in `lib/readline/complete.c`. Upstream patches (specifically around `bash52-037`) alter the file, introducing `__WIN32__` instead of `_WIN32` and changing the surrounding code. The local patch was updated to match this new state and ensure correct compilation on Android.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Fixed build failures by updating patches and build scripts to match current source code states for bash, coreutils, and libandroid-selinux.
PR created automatically by Jules for task 3902010246696709725 started by @SjnExe