Closed
Conversation
The linter also requires removing references to files in documentation, as well as to avoid unused code.
Sjors
force-pushed
the
sv2-sidecar
branch
2 times, most recently
from
2a2bde1 to
fec9345
Compare
Only leave the stratum v2 fuzzer.
Additionally: - use a different guix.sigs and detached-sigs repo (env variable) - drop bitcoin.conf and rpcauth from the archive
Sjors
added a commit
to stratum-mining/sv2-tp
that referenced
this pull request
Aug 27, 2025
This code is based on a stripped down and mofified version of Bitcoin Core, with Template Provider functionality added. It is identical to commit 8d9e276711b04b85aac2ae3f030bf5ac44c5194d from: Sjors/bitcoin#102 Although signficant portions of Bitcion Core node code are still included (mainly for the sv2_template_provider test), a full node can't be compiled and instead the user needs to connect to one. The only binaries produced are sv2_tp and sv2_tp_test.
Owner
Author
|
I copied the code as per the last commit 8d9e276 to a fresh repo: https://github.com/Sjors/sv2-tp |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This takes the Template Provider implemented in #48 and strips out everything from Bitcoin Core that it doesn't need. What's left will become a separate repo.
This approach has the benefit of giving the new Template Provider project some out of the box goodness from Bitcoin Core like deterministic builds and extensive CI.
At the same time the removal of lots of stuff will make it easier for others to understand the remaining code and contribute.
This can be used in conjunction with
bitcoin-nodewhich is included in Bitcoin Core v30+ (I plan to make a preview release).