Closed
Conversation
This was referenced Oct 16, 2024
Closed
Closed
Owner
Author
|
Rebased after a small merge conflict between 362d3d1 and probably bitcoin#31164. |
This was referenced Nov 22, 2024
Sjors
force-pushed
the
sv2-noise
branch
2 times, most recently
from
3cd1505 to
349218c
Compare
Sjors
force-pushed
the
sv2-transport
branch
2 times, most recently
from
9f5de22 to
e8737e0
Compare
Sjors
force-pushed
the
sv2-noise
branch
2 times, most recently
from
b627d33 to
0ddf522
Compare
Sjors
force-pushed
the
sv2-noise
branch
2 times, most recently
from
1d53afb to
78c95af
Compare
Sjors
commented
Mar 20, 2025
src/sv2/transport.cpp
Outdated
Owner
Author
There was a problem hiding this comment.
fd1f277cecc7cf38add72976ab41db444ed0131d: after rebasing on bitcoin#31519 I had to add .m_msg here or it wouldn't compile. I'm a bit surprised it worked before.
Sjors
force-pushed
the
sv2-noise
branch
2 times, most recently
from
83d5002 to
b012142
Compare
This commit adds the simplest stratum v2 message. The remaining messages are introduced in later commits.
This avoids a circular dependency between bitcoin-sv2 and bitcoin-node.
This allows us to subclass Transport.
Implemented starting from a copy of V2Transport and the V2TransportTester, modifying it to fit Stratum v2 and Noise Protocol requirements. Co-Authored-By: Christopher Coverdale <chris.coverdale24@gmail.com>
Owner
Author
|
Last rebase before I'm going to split off the sv2 functionality into a fresh codebase. |
Owner
Author
|
This code is now part of https://github.com/Sjors/sv2-tp; feedback and pull requests are welcome there! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces
Sv2Transport::Transportwhich is very similar toV2Transport.This shoehorns
Sv2NetMsginto aCSerializedNetMsginSetMessageToSend, and into aCNetMessageinGetReceivedMessage.See discussion in bitcoin#30209.
Moved here from bitcoin#30315.
Builds on:
Followed by #50. Parent PR #68.
Note that this code will most likely not be upstreamed to Bitcoin Core, but instead used to create a standalone c++ application that connects to a running node via an IPC interface. See bitcoin#31098.