Skip to content

Conversation

@sovdeeth
Copy link
Member

Problem

Type properties have been gated behind a hidden config option since 2.13, but need more broad testing before full release. This PR aims to enable them by default for users but provide an easy method to disable them if anything goes wrong.

Solution

Exposes the config option for type properties and sets it to enabled by default.
Also updates the property module to use Registration API!

Testing Completed

No new tests, ran quickTest.

Supporting Information


Completes: none
Related: none
AI assistance: none

@sovdeeth sovdeeth added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Dec 30, 2025
@sovdeeth sovdeeth requested a review from a team as a code owner December 30, 2025 19:21
@sovdeeth sovdeeth requested review from Pesekjak and cheeezburga and removed request for a team December 30, 2025 19:21
@skriptlang-automation skriptlang-automation bot added the needs reviews A PR that needs additional reviews label Dec 30, 2025
@sovdeeth sovdeeth moved this to In Review in 2.14 Releases Dec 30, 2025
Co-authored-by: Ilari Suhonen <ilari.suhonen@gmail.com>
sovdeeth and others added 2 commits December 30, 2025 13:55
@sovdeeth sovdeeth requested a review from a team as a code owner December 30, 2025 21:56
@sovdeeth sovdeeth requested review from UnderscoreTud and removed request for a team December 30, 2025 21:56
@skriptlang-automation skriptlang-automation bot added feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. and removed needs reviews A PR that needs additional reviews labels Jan 1, 2026
@github-project-automation github-project-automation bot moved this from In Review to Awaiting Merge in 2.14 Releases Jan 1, 2026
@APickledWalrus APickledWalrus merged commit 2eaa6e9 into SkriptLang:dev/feature Jan 1, 2026
9 checks passed
@github-project-automation github-project-automation bot moved this from Awaiting Merge to Done - Awaiting Release in 2.14 Releases Jan 1, 2026
@skriptlang-automation skriptlang-automation bot added completed The issue has been fully resolved and the change will be in the next Skript update. and removed feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. labels Jan 1, 2026
@APickledWalrus APickledWalrus moved this from Done - Awaiting Release to Done - Released in 2.14 Releases Jan 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

completed The issue has been fully resolved and the change will be in the next Skript update. enhancement Feature request, an issue about something that could be improved, or a PR improving something.

Projects

Status: Done - Released

Development

Successfully merging this pull request may close these issues.

4 participants