Skip to content

skills-fetch: default to anthropics + lambdatest (drop nvidia/trailofbits) - #43

Merged
JamesMaki merged 1 commit into
masterfrom
chore/skills-fetch-anthropic-lambdatest
Jul 22, 2026
Merged

skills-fetch: default to anthropics + lambdatest (drop nvidia/trailofbits)#43
JamesMaki merged 1 commit into
masterfrom
chore/skills-fetch-anthropic-lambdatest

Conversation

@JamesMaki

@JamesMaki JamesMaki commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

What

  • scripts/fetch_skills.sh: comment out the nvidia and trailofbits sources so fetch_skills.sh all pulls only anthropics + lambdatest. Both disabled sources stay in the file (commented in lookup() and the header) with a re-enable note; the usage example now points at a live source.
  • optimize/__init__.py: fix a stale lite-mode docstring on langfuse_available() — the miner no longer consults it or falls back to a local path (it fails loud via mine.py:fetch_traces), so the docstring now describes only the A/B gate's use.

Why

Narrow the default skill fetch to the two sources we want. While here, correct the one remaining inaccurate "local lite path" reference — master already removed the local JSONL trace store and made the miner fail loud, so the comment was the last stale remnant of the old lite mode.

Verification

  • docker build -t ingot-mcp . — clean
  • docker run --rm -v "$PWD:/app" -w /app ingot-mcp python -m pytest tests -q516 passed, 3 skipped

🤖 Generated with Claude Code

https://claude.ai/code/session_01URfKaRsuJqkcVQPkHzxKfP

Summary by CodeRabbit

  • Documentation

    • Clarified how Langfuse health-check results control whether holdout runs are logged as experiments versus run locally, including that miners fail loudly when no local fallback is available.
  • Chores

    • Updated default skill fetching to pull only from the Anthropic and LambdaTest sources.
    • Revised usage guidance accordingly; NVIDIA and Trail of Bits are no longer active by default.

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 6ce38bd2-0aca-448d-a2b9-d42c529f1eef

📥 Commits

Reviewing files that changed from the base of the PR and between 0cdeff4 and 2689a0a.

📒 Files selected for processing (2)
  • optimize/__init__.py
  • scripts/fetch_skills.sh
🚧 Files skipped from review as they are similar to previous changes (2)
  • optimize/init.py
  • scripts/fetch_skills.sh

📝 Walkthrough

Walkthrough

The changes update Langfuse availability documentation and restrict the skill-fetching script’s enabled sources to anthropics and lambdatest, disabling nvidia and trailofbits.

Changes

Langfuse documentation

Layer / File(s) Summary
Langfuse availability documentation
optimize/__init__.py
The langfuse_available() docstring now describes holdout experiment logging, local execution, and the miner’s lack of a local fallback.

Skill source selection

Layer / File(s) Summary
Restrict skill sources
scripts/fetch_skills.sh
Documentation and lookup logic now support anthropics and lambdatest by default, with nvidia and trailofbits disabled.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change to default skill fetching and is concise and specific.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/skills-fetch-anthropic-lambdatest

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@scripts/fetch_skills.sh`:
- Around line 40-46: Keep the source contract consistent between lookup() in
fetch_skills.sh and docs/skill-sources.md: either restore the nvidia and
trailofbits lookup arms while leaving them excluded from default SOURCES, or
update the documentation to mark both sources unsupported/disabled. Ensure
explicitly requested sources do not silently lack lookup results.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 856944bb-49b1-4253-b347-329b74026f8c

📥 Commits

Reviewing files that changed from the base of the PR and between 38d6d25 and 0cdeff4.

📒 Files selected for processing (2)
  • optimize/__init__.py
  • scripts/fetch_skills.sh

Comment thread scripts/fetch_skills.sh
…bits

Comment out the nvidia and trailofbits sources in scripts/fetch_skills.sh so
`fetch_skills.sh all` pulls only the Anthropic and LambdaTest skill sets.
Both disabled sources are retained (commented) in lookup() and the header with
a re-enable note; the usage example now references a live source.

Also fix a stale lite-mode docstring in optimize/langfuse_available(): the miner
no longer consults it or falls back to a local path (it fails loud), so the
docstring now describes only the A/B gate's use.

Claude-Session: https://claude.ai/code/session_01URfKaRsuJqkcVQPkHzxKfP
@JamesMaki
JamesMaki force-pushed the chore/skills-fetch-anthropic-lambdatest branch from 0cdeff4 to 2689a0a Compare July 22, 2026 15:08
@JamesMaki
JamesMaki merged commit 002f4aa into master Jul 22, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant