skills-fetch: default to anthropics + lambdatest (drop nvidia/trailofbits) - #43
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThe changes update Langfuse availability documentation and restrict the skill-fetching script’s enabled sources to ChangesLangfuse documentation
Skill source selection
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scripts/fetch_skills.sh`:
- Around line 40-46: Keep the source contract consistent between lookup() in
fetch_skills.sh and docs/skill-sources.md: either restore the nvidia and
trailofbits lookup arms while leaving them excluded from default SOURCES, or
update the documentation to mark both sources unsupported/disabled. Ensure
explicitly requested sources do not silently lack lookup results.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 856944bb-49b1-4253-b347-329b74026f8c
📒 Files selected for processing (2)
optimize/__init__.pyscripts/fetch_skills.sh
…bits Comment out the nvidia and trailofbits sources in scripts/fetch_skills.sh so `fetch_skills.sh all` pulls only the Anthropic and LambdaTest skill sets. Both disabled sources are retained (commented) in lookup() and the header with a re-enable note; the usage example now references a live source. Also fix a stale lite-mode docstring in optimize/langfuse_available(): the miner no longer consults it or falls back to a local path (it fails loud), so the docstring now describes only the A/B gate's use. Claude-Session: https://claude.ai/code/session_01URfKaRsuJqkcVQPkHzxKfP
JamesMaki
force-pushed
the
chore/skills-fetch-anthropic-lambdatest
branch
from
July 22, 2026 15:08
0cdeff4 to
2689a0a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
scripts/fetch_skills.sh: comment out thenvidiaandtrailofbitssources sofetch_skills.sh allpulls only anthropics + lambdatest. Both disabled sources stay in the file (commented inlookup()and the header) with a re-enable note; the usage example now points at a live source.optimize/__init__.py: fix a stale lite-mode docstring onlangfuse_available()— the miner no longer consults it or falls back to a local path (it fails loud viamine.py:fetch_traces), so the docstring now describes only the A/B gate's use.Why
Narrow the default skill fetch to the two sources we want. While here, correct the one remaining inaccurate "local lite path" reference — master already removed the local JSONL trace store and made the miner fail loud, so the comment was the last stale remnant of the old lite mode.
Verification
docker build -t ingot-mcp .— cleandocker run --rm -v "$PWD:/app" -w /app ingot-mcp python -m pytest tests -q→ 516 passed, 3 skipped🤖 Generated with Claude Code
https://claude.ai/code/session_01URfKaRsuJqkcVQPkHzxKfP
Summary by CodeRabbit
Documentation
Chores