Skip to content

Comments

Add more documentation, clean up launchd plist, upgrade dependencies#1

Open
jeffbyrnes wants to merge 9 commits intoSlgoetz:mainfrom
jeffbyrnes:main
Open

Add more documentation, clean up launchd plist, upgrade dependencies#1
jeffbyrnes wants to merge 9 commits intoSlgoetz:mainfrom
jeffbyrnes:main

Conversation

@jeffbyrnes
Copy link

No description provided.

* launchd agents & daemons are conventionally named in reverse
domain format
* Move $PATH into the plist
* UserName isn’t needed for a User-level launchd agent (i.e., one that
goes in ~/Library/LaunchAgents)
* StartCalendarInterval obviates StartInterval
* Use bash shebang in start.sh to simplify from ProgramArguments
to Program
$USERNAME is close enough to $USER (which exists in every macOS shell)
to be confusing, this avoids that.
3-space indentation is unusual, this ensures folks abide by it.
Otherwise you get URLs like this:

    FetchError: request to https://letterboxd.commovie/ failed
Signed-off-by: Jeff Byrnes <thejeffbyrnes@gmail.com>
Copy link

@yoclaire yoclaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants