Eliminate vcpkg dependency on Linux build#39
Open
SpookySkeletons wants to merge 1 commit intoSlimeVR:mainfrom
Open
Eliminate vcpkg dependency on Linux build#39SpookySkeletons wants to merge 1 commit intoSlimeVR:mainfrom
SpookySkeletons wants to merge 1 commit intoSlimeVR:mainfrom
Conversation
Author
|
Linux CI fails due to modified build process, pull in the necessary libs in with ubuntu's package manager. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linux has native system libs available which should both be utilized and left to distro package management. External packaging solutions like vcpkg should not be used to link these dependencies.
Please test this build on windows to confirm it still builds properly
Comment any necessary changes you see fit.
Build process now as follows:
cmake .
make