Search universes in Prop_DriverProvidedChaperoneJson_String#68
Search universes in Prop_DriverProvidedChaperoneJson_String#68ButterscotchV merged 3 commits intomainfrom
Conversation
|
I'm not exactly sure what's going on with CI here, it seems like the tests binary is not being statically linked against libopenvr_api.so... |
ButterscotchV
left a comment
ButterscotchV
left a comment
There was a problem hiding this comment.
Unsure about the openvr submodule update, but the code itself looks fine. My only suggestion is maybe we can log the universe source when it's found? I don't know if that would be spammy for no reason then, or if it would ever even really be useful. I can envision a situation where a driver reports both the JSON and the path for some reason, where they have differing values... Maybe SteamVR prevents such a case from happening? Regardless, I would be happy with this being merged, assuming the Linux side isn't broken.
|
Would it be possible to split the padded_string changes into a separate commit from the chaperone search changes? |
ImSapphire
force-pushed
the
sapphire/read-chaperone-json-prop
branch
from
76b5f82 to
04e3590
Compare
done |
ImSapphire
force-pushed
the
sapphire/read-chaperone-json-prop
branch
from
04e3590 to
8430129
Compare
ImSapphire
force-pushed
the
sapphire/read-chaperone-json-prop
branch
from
8430129 to
510d965
Compare
3 participants
Steam Link stores the chaperone data inside this property.