Conversation
Erimelowo
requested review from
ButterscotchV,
Eirenliel and
ImUrX
as code owners
Erimelowo
added
Status: Help Wanted
Member
|
What is this? For people on a boat? |
Member
Author
|
Yep |
Member
|
@Erimelowo What do we do about this? its been a draft for more than a year either update and ask us to review or close it please 🙏 |
Member
Author
|
It would be simpler to redo it from scratch since it’s relatively simple and too much of the related code changed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This currently requires the tracker to be aligned to the Identity rotation IRL, which isn't very user-friendly as users can only know where it is by trial and error. Input welcome on alternate ways to handle this.
needs SlimeVR/SolarXR-Protocol#141
closes #758