Conversation
TheDevMinerTV
requested changes
Mar 28, 2024
Member
TheDevMinerTV
left a comment
TheDevMinerTV
left a comment
There was a problem hiding this comment.
Please double check what changes are actually needed.
Contributor
Author
|
Rebased after #314 merging |
Member
|
Maybe we should put this behind a |
Contributor
Author
|
TheDevMinerTV
approved these changes
Mar 28, 2024
Eirenliel
requested changes
Oct 30, 2024
| } | ||
|
|
||
| { | ||
| networkConnection.sendRotationData(sensorId, &fusedRotation, DATA_TYPE_NORMAL, calibrationAccuracy); |
Member
There was a problem hiding this comment.
Suggested change
| networkConnection.sendRotationData(sensorId, &fusedRotation, DATA_TYPE_NORMAL, calibrationAccuracy); | |
| networkConnection.sendRotationData(sensorId, &lquat, DATA_TYPE_NORMAL, calibrationAccuracy); |
Shouldn't it be like that?
Also can be combined my taking lquat out of the define and having the same sendRotationData be used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds threading for ESP32 variants, allowing more sensors on a single ESP chip.
At current stage, threading mainly separates network packet building and networking stack from sensor operations.
Depending on #314