CON-1896 jobs progress by az-smartling · Pull Request #24 · Smartling/api-sdk-go

az-smartling · 2025-12-03T11:09:10Z

gemini-code-assist · 2025-12-03T11:09:26Z

Summary of Changes

Hello @az-smartling, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the job management capabilities of the API client by introducing new endpoints and data structures for retrieving job progress and filtering jobs by name. It involves a refactoring of existing job entity definitions into a dedicated file and an upgrade of the API version used for job-related operations, providing more comprehensive and organized access to job information.

Highlights

New Job Entity and Progress Definitions: Introduced new files api/job/ent_job.go and api/job/ent_job_progress.go to define job entity structures, job progress structures, and associated helper functions for converting raw API responses into these structured types.
Job API Interface and Implementation Updates: The Job interface in api/job/job.go has been updated to include new methods: GetAllByName for retrieving jobs by name and Progress for fetching job progress. The existing GetJob method was renamed to Get. The underlying httpJob implementation was also updated to support these new functionalities and reflect the API version change from v2 to v3.
Refactoring of Job Entity Code: The content of the api/job/job_ent.go file has been moved and integrated into the newly created api/job/ent_job.go file, leading to the removal of the former.
Minor Code Formatting: Minor formatting adjustments were made in helpers/sm_file/file_last_modified_request.go and helpers/sm_file/get_file_type_by_extension.go by removing unnecessary blank lines.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces new functionality for retrieving job progress and listing jobs by name, along with some code reorganization. The changes look good overall, but I've identified a few critical issues that should be addressed. These include a potential panic due to an index-out-of-range error, and resource leaks combined with incorrect response body handling in new HTTP client methods. I've also provided a suggestion to improve the signature of a new helper function for better idiomatic Go code. Please see the detailed comments for suggestions on how to resolve these issues.

api/job/ent_job.go

api/job/job.go

api/job/ent_job.go

dimitrystd · 2025-12-24T17:32:10Z

api/job/job.go

+
+// GetAllByName gets all jobs of a project by name
+func (h httpJob) GetAllByName(projectID, name string) ([]GetJobResponse, error) {
+	reqURL := jobBasePath + projectID + "/jobs"


Security training reminded me of our bad habits. It would be ideal if you could find a special library that can generate a valid URL path rather than concatenating strings. Let's do it once, and it will make future development easier because we can easily copy and paste best practices.

Changed to "path.Join"

dimitrystd · 2025-12-24T17:35:49Z

api/job/job.go

+}
+
+// GetAllByName gets all jobs of a project by name
+func (h httpJob) GetAllByName(projectID, name string) ([]GetJobResponse, error) {


Could you please research how to add validation for input parameters? An example for this specific case: we must check that parameters are not empty and projectID follows specific patterns.

P.S. Well, I do not want to broaden the scope of this ticket/PR. Let's make a Jira ticket for research on how to use a declarative approach for validation (rather than imerative).

We can do simple checks. If var is not empty etc. More complex checks could bring errors when in SDK var is invalid when in API the var is valid.

dimitrystd · 2026-01-24T23:42:53Z

api/job/job.go

-func (h httpJob) GetJob(projectID string, translationJobUID string) (GetJobResponse, error) {
+// Get gets a job related info
+func (h httpJob) Get(projectID string, translationJobUID string) (GetJobResponse, error) {
 	url := jobBasePath + projectID + "/jobs/" + translationJobUID


nit: I already proposed to avoid unsafe string concatenation. It would be great to use path.Join() and url.PathEscape(). Thanks

dimitrystd · 2026-01-24T23:45:53Z

api/job/ent_job_progress.go

+	}
+	return GetJobProgressResponse{
+		TranslationJobUID: translationJobUID,
+		TotalWordCount:    uint32(r.Response.Data.Progress.TotalWordCount),


Why do we use a mix of int and uint32. Can we use int everywhere (in type definitions)?

Can we use uint32? Most likely TotalWordCount cannot be less zero.

dimitrystd · 2026-01-24T23:49:28Z

api/job/job.go

+
+// GetAllByName gets all jobs of a project by name
+func (h httpJob) GetAllByName(projectID, name string) ([]GetJobResponse, error) {
+	reqURL := path.Join(jobBasePath, url.PathEscape(projectID), "jobs")


nit: In the method above you call variable url. Could you pls use the same variable name in the file (just for consitency).

CON-1896 jobs progress

ec19f74

gemini-code-assist bot reviewed Dec 3, 2025

View reviewed changes

api/job/ent_job.go Outdated Show resolved Hide resolved

api/job/job.go Show resolved Hide resolved

api/job/job.go Show resolved Hide resolved

api/job/ent_job.go Outdated Show resolved Hide resolved

fixed jobBasePath

6cb1a9c

az-smartling mentioned this pull request Dec 3, 2025

Con 1896 jobs progress Smartling/smartling-cli#95

Open

az-smartling added 2 commits December 3, 2025 17:40

updated make slice

535aa85

CR changes

3d4239a

az-smartling requested a review from dimitrystd December 3, 2025 16:55

dimitrystd requested changes Dec 24, 2025

View reviewed changes

CR changes

98292be

az-smartling requested a review from dimitrystd January 22, 2026 19:36

Merge branch 'master' into CON-1896_jobs_progress

79d0084

dimitrystd reviewed Jan 24, 2026

View reviewed changes

dimitrystd mentioned this pull request Jan 24, 2026

Resource leak in batches.GetStatus() - missing defer Close() #27

Open

5 tasks

Use the same var names. More usage of path.Join.

e8c40c9

az-smartling requested a review from dimitrystd January 26, 2026 11:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CON-1896 jobs progress#24

CON-1896 jobs progress#24
az-smartling wants to merge 7 commits intomasterfrom
CON-1896_jobs_progress

az-smartling commented Dec 3, 2025 •

edited

Loading

Uh oh!

gemini-code-assist bot commented Dec 3, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dimitrystd Dec 24, 2025

Uh oh!

az-smartling Jan 22, 2026

Uh oh!

dimitrystd Dec 24, 2025

Uh oh!

az-smartling Jan 26, 2026

Uh oh!

dimitrystd Jan 24, 2026

Uh oh!

dimitrystd Jan 24, 2026

Uh oh!

az-smartling Jan 26, 2026

Uh oh!

dimitrystd Jan 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

az-smartling commented Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist bot commented Dec 3, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

az-smartling commented Dec 3, 2025 •

edited

Loading