Skip to content

fix reset of multi-value Properties #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sdumetz wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix reset of multi-value Properties #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 2 additions & 20 deletions source/Property.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,26 +397,8 @@ export default class Property<T = any> extends Publisher

reset()
{
let value;

if (this.isMulti()) {
let multiArray: T[] = this.value as any;

if (!multiArray) {
value = multiArray = [] as any;
}
else {
multiArray.length = 1;
}

multiArray[0] = this.clonePreset();
}
else {
value = this.clonePreset();
}

// set changed flag and push to output links
this.setValue(value);
this.setValue(this.clonePreset());
}

setMultiChannelCount(count: number)
Expand Down Expand Up @@ -477,7 +459,7 @@ export default class Property<T = any> extends Publisher
return Array.isArray(this.schema.preset);
}

isMulti(): boolean
isMulti(): this is Property<any[]>
{
return !!this.schema.multi;
}
Expand Down