Skip to content

Change the non-obvious execution settings layout#308

Open
s-vitaliy wants to merge 2 commits into
mainfrom
fix-execution-settings-layout
Open

Change the non-obvious execution settings layout#308
s-vitaliy wants to merge 2 commits into
mainfrom
fix-execution-settings-layout

Conversation

@s-vitaliy

@s-vitaliy s-vitaliy commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Fixes #305

Scope

As discussed, the new layout is the following:

  execution:
    streamingBackend:
      batch:
        schedule: "*/30 * * * *"
        jobTemplateRef:
          kind: StreamingJobTemplate
          name: job-template
          namespace: default

or

  execution:
    streamingBackend:
      changeTracking:
        backfillJobTemplateRef:
          kind: StreamingJobTemplate
          name: backfill-template
          namespace: default
        jobTemplateRef:
          kind: StreamingJobTemplate
          name: job-template
          namespace: backfill

NOTE the layout version will not be changed since the change affects beta streams only.

Checklist

  • GitHub issue exists for this change.
  • Unit tests added and they pass.
  • Line Coverage is at least 80%.
  • Review requested on latest commit.

Fixes #305

As discussed, the new layout is the following:
```
  execution:
    streamingBackend:
      batch:
        schedule: "*/30 * * * *"
        jobTemplateRef:
          kind: StreamingJobTemplate
          name: job-template
          namespace: default
```

or

```
  execution:
    streamingBackend:
      changeTracking:
        backfillJobTemplateRef:
          kind: StreamingJobTemplate
          name: backfill-template
          namespace: default
        jobTemplateRef:
          kind: StreamingJobTemplate
          name: job-template
          namespace: backfill
```
@github-actions

Copy link
Copy Markdown

go-test-coverage report:

Package coverage threshold (70%) satisfied:	PASS
Total coverage threshold (75%) satisfied:	PASS
Total test coverage: 88.3% (709/803)

@s-vitaliy s-vitaliy changed the title Change an unobvious execution settings layout Change the non-obvious execution settings layout Jul 16, 2026
@s-vitaliy
s-vitaliy marked this pull request as ready for review July 16, 2026 14:00
@s-vitaliy
s-vitaliy requested a review from a team as a code owner July 16, 2026 14:00
@s-vitaliy
s-vitaliy requested a review from timonviola July 16, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Scheduled job definition requires both backfillJobTemplateRef and streaming.Backend.batch.jobTemplateRef even though only the later is used

1 participant