Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1707 +/- ##
==========================================
- Coverage 81.58% 78.70% -2.89%
==========================================
Files 22 24 +2
Lines 994 1000 +6
Branches 184 186 +2
==========================================
- Hits 811 787 -24
- Misses 166 187 +21
- Partials 17 26 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I changed the contract addresses on Westend-Sepolia to add #1709: |
There was a problem hiding this comment.
Is it possible to rename this to a more generic Gateway202602.sol? There's nothing specific about Sepolia in this contract. I'd also like to use it for the mainnet deployment.
Also can you confirm whether we need any special initializer config for mainnet?
There was a problem hiding this comment.
I’ve added a separate configuration for mainnet and would prefer to keep the existing Westend deployment (already executed) unchanged.
can you confirm whether we need any special initializer config for mainnet?
No, this only updates BeefyClient for Fiat–Shamir and includes an internal processing revamp in v2_submit to make dry runs easier. No migration is required.
| } | ||
| } | ||
|
|
||
| function mainnetConfig() internal pure returns (Config memory config) { |
There was a problem hiding this comment.
Would appreciate if you can refresh the init config for the mainnet deployment. Then I can deploy tomorrow morning.
There was a problem hiding this comment.
Updated configuration is available here: 494b908
By the way, we already have a script to fetch the latest BEEFY checkpoint. Alternatively, you can simply run:
➜ contracts ./scripts/beefy-checkpoint.js
to fetch the latest checkpoint for the deployment.
| gatewayLogic = new GatewaySepolia202602(address(beefyClient), address(executor)); | ||
| } | ||
|
|
||
| console.log("Gateway contract address: %s", address(gatewayLogic)); |
There was a problem hiding this comment.
Should also log the NODE_ENV. And come to think about it, can we rename NODE_ENV to STAGE? This isn't a js app.
There was a problem hiding this comment.
Makes sense, but I prefer SNOWBRIDGE_DEPLOY_STAGE over STAGE, since STAGE is a bit too generic and could potentially conflict with existing environment variables.
470d1f8#diff-9eea76d09975284c56e96f0effa9e2302b231b3bf561bacb7880930c66d1d620
yrong
force-pushed
the
ron/upgrade-gateway-202602-on-sepolia
branch
from
d8c43db to
72f7a35
Compare
| // Todo: Update Beefy client address on Polkadot mainnet with the correct one before deploying. | ||
| address beefyClient = 0x1817874feAb3ce053d0F40AbC23870DB35C2AFfc; | ||
| gatewayLogic = new Gateway202602(address(beefyClient), address(executor)); |
There was a problem hiding this comment.
@vgeddes Just a reminder to update the BeefyClient address here before deploying the new Gateway contract.
There was a problem hiding this comment.
By the way, please also check whether #1726 can be merged or included in the deployment.
3 participants
Upgrade on Sepolia
https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Fwestend-rpc.polkadot.io#/extrinsics/decode/0x630004000100a90f040c2f00000602070008d6e82982ee3600dc5300ec6d80d1e444c304d684acc6285c8f823fdd7344c2e4fc80a3888aa6c64a5e1b5f9878f3c0bd7d6c5ed0e03069c02de1a870e639002000
Upgrade on Mainnet