fix: harden GitHub Actions workflows#12
Merged
Merged
Conversation
- Upgrade actions/checkout to v6.0.2 and add persist-credentials: false
- Add workflow-level permissions: {} to release.yml and contents: read to test.yml
- Replace secrets: inherit with explicit secret passing (SOCKET_API_KEY)
- Disable caching in release workflow setup-bun to prevent cache poisoning
- Declare SOCKET_API_KEY as optional workflow_call secret in test.yml
- Disable secrets-outside-env rule via .github/zizmor.yml
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Ryan Eberhardt (reberhardt7)
changed the title
Ahmad Nassri (ahmadnassri)
approved these changes
Mar 25, 2026
Ahmad Nassri (ahmadnassri)
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
actions/checkoutto v6.0.2 withpersist-credentials: falseto prevent credential leakage (artipacked)permissionsblocks to both workflows (excessive-permissions)secrets: inheritwith explicit secret passing of onlySOCKET_API_KEY(secrets-inherit).github/zizmor.ymlto disablesecrets-outside-envruleRemaining findings
cache-poisoningwarning (high) ontest.ymlsetup-bundue toworkflow_calltrigger — this is a CI workflow that does not publish artifacts, so caching is safe and intentionally kept