Skip to content

fix: race condition where artifacts from late resolving flights could be silently dropped#14

Closed
Bill Li (billxinli) wants to merge 2 commits into
mainfrom
SMO-633
Closed

fix: race condition where artifacts from late resolving flights could be silently dropped#14
Bill Li (billxinli) wants to merge 2 commits into
mainfrom
SMO-633

Conversation

@billxinli

Copy link
Copy Markdown
  • Fix race condition where fetchStrategy pushed into a shared artifacts array by reference late resolving flights could write into a stale array that had already been yielded, silently dropping results
  • Change fetchStrategy to return artifacts instead of mutating a passed in array, so the scanner factory controls when results are merged via a closure that always reads the current array
  • Add tests covering late-resolving flights

@jdalton

Copy link
Copy Markdown
Collaborator

Closing as stale — please feel free to re-open if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants