feat(http-request): add readIncomingResponse and type aliases#143
Merged
Conversation
Add readIncomingResponse() to read and buffer a client-side IncomingResponse into an HttpResponse. Useful for converting raw responses from code that bypasses httpRequest() (e.g. multipart form-data uploads) into the standard HttpResponse interface. Add IncomingResponse and IncomingRequest type aliases to disambiguate Node's IncomingMessage which is used for both client responses and server requests.
John-David Dalton (jdalton)
force-pushed
the
feat/read-incoming-message
branch
from
d1abdaa to
582615f
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
readIncomingResponse(msg)— reads and buffers a client-sideIncomingResponseinto anHttpResponse. Useful for converting raw responses from code that bypasseshttpRequest()(e.g. multipart form-data uploads) into the standardHttpResponseinterface.IncomingResponsetype alias —IncomingMessagereceived as a response to a client requestIncomingRequesttype alias —IncomingMessagereceived as a request in a server handlerhttpRequestAttemptcallbacks to useIncomingResponse@socketsecurity/lib/http-requestWhy the type aliases
Node's
IncomingMessageis used for both client responses and server requests. The aliases disambiguate which context you're in, making call sites self-documenting.Test plan
readIncomingResponse: JSON, text, 404, 500, binary, arrayBuffer, large bodies, undefined statusCode, header preservation, invalid JSON from.json(), parity withhttpRequestoutput