fix: eliminate Promise.race handler-stacking in claude.mts worker pool#184
Closed
John-David Dalton (jdalton) wants to merge 2 commits into
Closed
fix: eliminate Promise.race handler-stacking in claude.mts worker pool#184John-David Dalton (jdalton) wants to merge 2 commits into
John-David Dalton (jdalton) wants to merge 2 commits into
Conversation
The parallel task runner called `Promise.race(executing)` every loop iteration against the whole in-flight pool. Each race re-attached fresh `.then` handlers to every still-pending promise, so long-lived tasks accumulated O(iterations-they-survived) dead handler closures before finally settling. See nodejs/node#17469 and https://github.com/cefn/watchable/tree/main/packages/unpromise. Switch to a single-waiter "slot available" signal: each task's .then releases one slot and resolves the current waiter (if any). The main loop awaits a one-shot waitForSlot() promise that's garbage-collected after it fires — no persistent pool, nothing to stack.
Pairs with the claude.mts worker-pool fix: documents the anti-pattern so future code does not reintroduce it.
Collaborator
Author
|
Landing directly on main per user direction — changes preserved. |
John-David Dalton (jdalton)
deleted the
fix/promise-race-handler-stacking
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/claude.mts): The parallel task runner calledPromise.race(executing)every loop iteration against the whole in-flight pool. Each race re-attached fresh.thenhandlers to every still-pending promise, so long-lived tasks accumulatedO(iterations_survived)dead handler closures before finally settling. See nodejs/node#17469 and @watchable/unpromise for the pattern..thenreleases one slot and resolves the current waiter (if any). The main loop awaits a one-shotwaitForSlot()promise — no persistent pool, nothing to stack.CLAUDE.md): added a concise rule under SHARED STANDARDS so the pattern is not reintroduced.Test plan