Skip to content

fix(card-onboard): mobile bottom inset and close fees modal on Get-yo… #2054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MusabShakeel576 merged 1 commit into from
May 7, 2026
+5 −3
Merged

fix(card-onboard): mobile bottom inset and close fees modal on Get-yo… #2054

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/CardWaitlist/CardFeesModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ const CardFeesModal = ({ isOpen, onOpenChange }: CardFeesModalProps) => {
</View>

<AuthButton>
<GetCardButton className="w-full" />
<GetCardButton className="w-full" onPress={() => onOpenChange(false)} />
</AuthButton>
</View>
</ResponsiveModal>
Expand Down
2 changes: 1 addition & 1 deletion components/CardWaitlist/CardWaitlistPageMobile.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ const CardWaitlistPageMobile = () => {
scrollable={false}
additionalContent={<CardFeesModal isOpen={feesOpen} onOpenChange={setFeesOpen} />}
>
<View className="flex-1 px-5 pb-4 pt-2">
<View className="flex-1 px-5 pb-24 pt-2">
<View className="flex-1 items-center justify-center">
<Image
source={getAsset('images/cards.png')}
Expand Down
4 changes: 3 additions & 1 deletion components/CardWaitlist/GetCardButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,14 @@ import { cn } from '@/lib/utils';

interface GetCardButtonProps {
className?: string;
onPress?: () => void;
}

const GetCardButton = ({ className }: GetCardButtonProps) => {
const GetCardButton = ({ className, onPress }: GetCardButtonProps) => {
const router = useRouter();

const handleGetCard = async () => {
onPress?.();
track(TRACKING_EVENTS.CARD_GET_CARD_PRESSED, {
source: 'card_waitlist',
});
Expand Down
Loading